SimplePool setPoolSize incorrectly updates internal fields #3143
Labels
Comments
garyrussell
added a commit
to garyrussell/spring-integration
that referenced
this issue
Jan 16, 2020
- use preferred assertJ expected exception checking - add a test for reducing a partially allocated pool
garyrussell
added a commit
to garyrussell/spring-integration
that referenced
this issue
Jan 16, 2020
- use preferred assertJ expected exception checking - add a test for reducing a partially allocated pool - check active counts
garyrussell
added a commit
to garyrussell/spring-integration
that referenced
this issue
Jan 16, 2020
- use preferred assertJ expected exception checking - add a test for reducing a partially allocated pool - check active counts
garyrussell
pushed a commit
that referenced
this issue
Jan 16, 2020
Resolves spring-projects/spring-amqp#1142 Resize down does not work when not enough already allocated to match the reduction. Improved SimplePool test cases and fixed code style Fixed code style GH-3143: Test Polishing - use preferred assertJ expected exception checking - add a test for reducing a partially allocated pool - check active counts
garyrussell
pushed a commit
that referenced
this issue
Jan 16, 2020
Resolves spring-projects/spring-amqp#1142 Resize down does not work when not enough already allocated to match the reduction. Improved SimplePool test cases and fixed code style Fixed code style GH-3143: Test Polishing - use preferred assertJ expected exception checking - add a test for reducing a partially allocated pool - check active counts
|
Fixed via dba307a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
When new pool size is less then existing, setPoolSize() method breaks consistency.
This happens when CachingSessionFactory is constructed using the most "convenient" constructor
CachingSessionFactory(SessionFactory<F> sessionFactory). In this case initial poolSize=Integer.MAX_VALUE. And so when later we are trying to setup some other value, the pool object becomes broken.The text was updated successfully, but these errors were encountered: