Skip to content

Return registration_endpoint in OidcProviderConfigurationEndpointFilter #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bibibiu2017 opened this issue Jul 24, 2021 · 7 comments
Closed
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@bibibiu2017
Copy link
Contributor

Describe the bug
OpenId configuration metadata endpoint does not return registration endpoint even though dynamic client registration it was implemented in gh-189

To Reproduce
http://auth-server/.well-known/openid-configuration
returns

{
    "issuer": "http://localhost:8000/authorization",
    "authorization_endpoint": "http://localhost:8000/authorization/oauth2/authorize",
    "token_endpoint": "http://localhost:8000/authorization/oauth2/token",
    "token_endpoint_auth_methods_supported": [
        "client_secret_basic",
        "client_secret_post"
    ],
    "jwks_uri": "http://localhost:8000/authorization/oauth2/jwks",
    "response_types_supported": [
        "code"
    ],
    "grant_types_supported": [
        "authorization_code",
        "client_credentials",
        "refresh_token"
    ],
    "subject_types_supported": [
        "public"
    ],
    "id_token_signing_alg_values_supported": [
        "RS256"
    ],
    "scopes_supported": [
        "openid"
    ]
}

Expected behavior
Should contain the client registration endpoint

@bibibiu2017 bibibiu2017 added the type: bug A general bug label Jul 24, 2021
bibibiu2017 added a commit to bibibiu2017/spring-authorization-server that referenced this issue Jul 24, 2021
bibibiu2017 added a commit to bibibiu2017/spring-authorization-server that referenced this issue Jul 24, 2021
bibibiu2017 added a commit to bibibiu2017/spring-authorization-server that referenced this issue Jul 25, 2021
@jgrandja jgrandja added type: enhancement A general enhancement and removed type: bug A general bug labels Jul 28, 2021
@jgrandja jgrandja assigned bibibiu2017 and unassigned jgrandja Jul 28, 2021
@jgrandja jgrandja added this to the 0.2.0 milestone Jul 28, 2021
@jgrandja jgrandja changed the title Add Registration Endpoint To OpenId Configuration Endpoint Filter Return registration_endpoint in OidcProviderConfigurationEndpointFilter Jul 28, 2021
bibibiu2017 added a commit to bibibiu2017/spring-authorization-server that referenced this issue Jul 28, 2021
bibibiu2017 added a commit to bibibiu2017/spring-authorization-server that referenced this issue Jul 28, 2021
bibibiu2017 added a commit to bibibiu2017/spring-authorization-server that referenced this issue Jul 29, 2021
Spring Authorization Server now supports dynamo open id client registration but the client registration url was not included in open id Configuration metadata. This has been added by this commit.

closes spring-projectsgh-370
bibibiu2017 added a commit to bibibiu2017/spring-authorization-server that referenced this issue Jul 29, 2021
Spring Authorization Server now supports dynamo open id client registration but the client registration url was not included in open id Configuration metadata. This has been added by this commit.

closes spring-projectsgh-370
bibibiu2017 added a commit to bibibiu2017/spring-authorization-server that referenced this issue Jul 29, 2021
Spring Authorization Server now supports dynamo open id client registration but the client registration url was not included in open id Configuration metadata. This has been added by this commit.

closes spring-projectsgh-370
bibibiu2017 added a commit to bibibiu2017/spring-authorization-server that referenced this issue Aug 5, 2021
…ration but the client registration url was not included in open id Configuration metadata. This has been added by this commit.

closes spring-projectsgh-370
@jgrandja jgrandja modified the milestones: 0.2.0, 0.2.1 Aug 17, 2021
@jgrandja jgrandja removed this from the 0.2.1 milestone Oct 25, 2021
@sahariardev
Copy link
Contributor

hi @jgrandja. Can I work on this issue?

@jgrandja
Copy link
Collaborator

Thanks for your interest @sahariardev.

We're holding off on adding new features and enhancements until after we release 0.3.0.

Our top priority for 0.3.0 is to deliver the initial version of the reference documentation.
We still have a lot of work to do so we need to keep focused.

Please reach out again after 0.3.0 is released May 23.

@sahariardev
Copy link
Contributor

Thanks for the reply. I will reach out after 0.3.0 release.

@sahariardev
Copy link
Contributor

hi @jgrandja,
Can I work on this issue?

@jgrandja
Copy link
Collaborator

@sahariardev Yes, the issue is yours.

Please keep in mind that OidcProviderConfigurationEndpointFilter should return the registration_endpoint ONLY if the OpenID Connect 1.0 Client Registration Endpoint is enabled - it's disabled by default.

@sahariardev
Copy link
Contributor

sahariardev commented May 31, 2022

Thanks for the reply. I will keep that in mind

@sahariardev
Copy link
Contributor

Hi @jgrandja,
I have created a Draft PR for this issue. Please review and let me know your feedbacks.
Here is the PR link
#762

sahariardev added a commit to sahariardev/spring-authorization-server that referenced this issue Sep 2, 2022
Before: client registration endpoint was not retuned in oidc
Provider Configuration response

After: Returns client registration endpoint in oidcprovider configuration
response if client registration is enabled

Fixes spring-projectsgh-370
sahariardev added a commit to sahariardev/spring-authorization-server that referenced this issue Sep 3, 2022
Before: client registration endpoint was not retuned in oidc
Provider Configuration response

After: Returns client registration endpoint in oidcprovider configuration
response if client registration is enabled

Fixes spring-projectsgh-370
sahariardev added a commit to sahariardev/spring-authorization-server that referenced this issue Sep 3, 2022
Before: client registration endpoint was not retuned in oidc
Provider Configuration response

After: Returns client registration endpoint in oidcprovider configuration
response if client registration is enabled

Fixes spring-projectsgh-370
sahariardev added a commit to sahariardev/spring-authorization-server that referenced this issue Sep 9, 2022
Before: client registration endpoint was not retuned in oidc
Provider Configuration response

After: Returns client registration endpoint in oidcprovider configuration
response if client registration is enabled

Fixes spring-projectsgh-370
@jgrandja jgrandja added this to the 0.4.0-M2 milestone Sep 20, 2022
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment