Return registration_endpoint in OidcProviderConfigurationEndpointFilter #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Old PR link #762 |
spring-projects-issues
added
the
status: waiting-for-triage
sahariardev
force-pushed
the
return_registration_endpoint_in_oidcProviderConfigurationEndpointFilter
branch
2 times, most recently
from
2db51fc to
3e90c2c
Compare
|
Hi @jgrandja, |
jgrandja
added
status: duplicate
jgrandja
requested changes
Sep 7, 2022
There was a problem hiding this comment.
Thanks for the updates @sahariardev. Please see review comments.
...k/security/oauth2/server/authorization/config/annotation/web/configurers/OidcConfigurer.java
Outdated
Show resolved
Hide resolved
...ramework/security/oauth2/server/authorization/AbstractOAuth2AuthorizationServerMetadata.java
Outdated
Show resolved
Hide resolved
...mework/security/oauth2/server/authorization/OAuth2AuthorizationServerMetadataClaimNames.java
Show resolved
Hide resolved
...ramework/security/oauth2/server/authorization/AbstractOAuth2AuthorizationServerMetadata.java
Outdated
Show resolved
Hide resolved
...mework/security/oauth2/server/authorization/OAuth2AuthorizationServerMetadataClaimNames.java
Outdated
Show resolved
Hide resolved
...ramework/security/oauth2/server/authorization/AbstractOAuth2AuthorizationServerMetadata.java
Outdated
Show resolved
Hide resolved
Before: client registration endpoint was not retuned in oidc Provider Configuration response After: Returns client registration endpoint in oidcprovider configuration response if client registration is enabled Fixes spring-projectsgh-370
sahariardev
force-pushed
the
return_registration_endpoint_in_oidcProviderConfigurationEndpointFilter
branch
from
3e90c2c to
f1eb744
Compare
|
Hi @jgrandja, |
|
Thanks for all the updates @sahariardev. This is now merged. FYI, I added a polish commit with some minor updates. |
jgrandja
added a commit
that referenced
this pull request
Sep 20, 2022
The following commits are merged using the default merge strategy. 80b0185 Update README with documentation links 4d94e70 Decompose OAuth2AuthorizationCodeRequestAuthenticationProvider cd6f1d7 Return registration_endpoint when client registration is enabled 26aed3c Polish gh-881 92dbcf2 Move integration tests for OidcProviderConfiguration
doba16
pushed a commit
to doba16/spring-authorization-server
that referenced
this pull request
Apr 21, 2023
doba16
pushed a commit
to doba16/spring-authorization-server
that referenced
this pull request
Apr 21, 2023
The following commits are merged using the default merge strategy. ccdd8ce Update README with documentation links c70255a Decompose OAuth2AuthorizationCodeRequestAuthenticationProvider 8d51722 Return registration_endpoint when client registration is enabled fdf1200 Polish spring-projectsgh-881 aee5613 Move integration tests for OidcProviderConfiguration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: client registration endpoint was not retuned in oidc
Provider Configuration response
After: Returns client registration endpoint in oidcprovider configuration
response if client registration is enabled
Fixes gh-370