Skip to content

Remove image banner support #28883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Dec 1, 2021 · 3 comments
Closed

Remove image banner support #28883

philwebb opened this issue Dec 1, 2021 · 3 comments
Assignees
@wilkinsona
Labels
theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
3.0.0-M2

Comments

@philwebb
Copy link
Member

philwebb commented Dec 1, 2021 •
edited by scottfrederick
Loading

Image banners rely on awt classes to convert the gif/png/jpeg file to text. They also convert the image on each run of the application. It would probably be better to remove support and instead offer a tool that can be run once to convert an image to a banner files. It would also help solve the "headless" issue identified in #28803
@philwebb philwebb added this to the 3.x milestone Dec 1, 2021
@philwebb philwebb added the type: enhancement A general enhancement label Dec 1, 2021
@rudy2steiner
Copy link

Let me try this!

@wilkinsona wilkinsona self-assigned this Feb 2, 2022
@wilkinsona wilkinsona modified the milestones: 3.x, 3.0.0-M2 Feb 2, 2022
@wilkinsona
Copy link
Member

I have removed support for image-based banners. A replacement tool has not been added as it's not clear to me that there is sufficient demand for one in Spring Boot itself. We could consider adding such a tool to the CLI if there's sufficient demand in the future.

@joshlong
Copy link
Member

I understand the reasoning. It makes good sense. But I am sad.

@mbhave mbhave added the theme: aot An issue related to Ahead-of-time processing label Jun 27, 2022
@wilkinsona wilkinsona mentioned this issue Sep 1, 2022
Closed
scottfrederick added a commit that referenced this issue Sep 29, 2022
@scottfrederick
Remove image banner smoke test
2e4529d 
See gh-28883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.0-M2
Development

No branches or pull requests
5 participants
@joshlong @philwebb @wilkinsona @mbhave @rudy2steiner