Skip to content

Remove AnsiColors #32209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Sep 1, 2022 · 3 comments
Closed

Remove AnsiColors #32209

wilkinsona opened this issue Sep 1, 2022 · 3 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

It was added as part of image banner support and image banner support was removed in 3.0.0-M2. AnsiColors should have been removed at that time. This issue will correct that oversight.

@wilkinsona wilkinsona self-assigned this Sep 1, 2022
@wilkinsona wilkinsona added this to the 3.0.0-M5 milestone Sep 1, 2022
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Sep 1, 2022
@meiMingle
Copy link

No, I disagree, I think maybe AnsiColors deserves to be kept. It is useful for generating Ascii Art style banners, for example I can use it to generate colored QR codes like the one below. If AnsiColors is removed, it is a big hassle to manually handle the conversion from Color to AnsiColor, AnsiBackground, Ansi8bitColor.
image

@meiMingle
Copy link

Although AnsiColors was originally used to support image banners, it should not only be seen as a part of image banners, it plays an important role in processing text banners into colored Ascii Art banners, as in the picture above.

@wilkinsona
Copy link
Member Author

wilkinsona commented Sep 1, 2022

Unfortunately, as we no longer have any need for it in Spring Boot I don't think we can justify the ongoing cost of maintaining and enhancing it. Given Spring Boot's permissive Apache v2 licence, you are free to copy the source code into your own application and maintain it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants