Optimize the conversion of AnsiColor #32181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meiMingle Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@meiMingle Thank you for signing the Contributor License Agreement! |
r331
reviewed
Aug 29, 2022
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/ansi/AnsiColors.java
Outdated
Show resolved
Hide resolved
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/ansi/AnsiColors.java
Outdated
Show resolved
Hide resolved
|
Hello, is anyone following this Pr? |
|
Thanks for the PR. Unfortunately, AnsiColors should have been removed as part of removing support for image-based banners. I have opened #32209 to correct this oversight. |
wilkinsona
added
status: declined
|
It is recommended to reconsider this action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original AnsiColors class does not contain the processing of AnsiBackground and Ansi8BitColor.background(xxx), this Pr supplements this.