Skip to content

Move dynamic mapping parameter configuration to @Document and @Field #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Jul 15, 2021

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our [issue tracker](https://github.
    com/spring-projects/spring-data-elasticsearch/issues)
    . Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #1871

@xhaggi xhaggi requested a review from sothawo July 15, 2021 11:49
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 15, 2021
@xhaggi xhaggi force-pushed the 1871-rewrite-dynamic-mapping-parameter branch from a6ad6c1 to 53c24e1 Compare July 15, 2021 11:53
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor remarks, a failing test class

@xhaggi xhaggi force-pushed the 1871-rewrite-dynamic-mapping-parameter branch from 2057b12 to 40087da Compare July 19, 2021 08:55
@xhaggi xhaggi requested a review from sothawo July 19, 2021 08:55
@sothawo sothawo merged commit f74dd87 into spring-projects:main Jul 20, 2021
@xhaggi xhaggi deleted the 1871-rewrite-dynamic-mapping-parameter branch July 20, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move dynamic mapping parameter configuration to @Document and @Field
3 participants