#235: added support for RFC 5988 Target Attributes to the Link class #240
Conversation
|
Again, I'd love to hear about the rationale for this change. "I'd like to see the attributes" is not gonna cut it. Be sure to understand that we're basically a mitigating library that needs to be careful not to add attributes that the media types we support don't support in turn. Especially if we run into scenarios with conflicting or ambiguous attribute semantics. Going forward, please make sure you add a few more explanations with your pull requests as simply throwing some code over the fence is not gonna work out anyway. |
|
I would expect that any hateoas media type that included links would be required to support all RFC-5988 target attributes, since this is the official standard for links. RFC-5988 also allows links to have custom attributes added. Yes, I'll be sure to put for details in from now on. |
|
This is a prerequisite for handling secondary key lookups in HAL. Even without that feature, if the attributes aren't parsed at all they can't be inspected by client code manually. This really cripples link collections. |
odrotbohm
force-pushed
the
master
branch
2 times, most recently
from
4ebc1be to
266ad50
Compare
|
According to the HAL spec, the only required attribute is href. All others are optional. We have presently implemented templated because it's critically needed for any controller with arguments. Something more is needed for any of the other attributes to be added. Otherwise, they can easily appear as superfluous bits. |
|
Similar to #100 |
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module. Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out. Resolves #100,#417,#235,#240,#238,#223
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module. Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out. Resolves #100,#417,#235,#240,#238,#223
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module. Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out. Resolves #100,#417,#235,#240,#238,#223
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module. Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out. Resolves #100,#417,#235,#240,#238,#223
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module. Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out. Resolves #100,#417,#235,#240,#238,#223
|
@jstano Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module. Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out. Resolves #100,#417,#235,#240,#238,#223
|
Superseded by #567. |
No description provided.