Add type and title properties to Link class

[tony-kerz]

Simple proposal for change to allow type and title properties to Link class, of course, on board with any alternate which allows for same end result. The following example set values for new 'title' property of Link:

[ {
  "links" : [ {
    "rel" : "self",
    "href" : "http://localhost:8080/acme-widget-hateoas-web-api/widgets/1"
  } ],
  "name" : "widget-0",
  "whatsitLinks" : [ {
    "rel" : "whatsit",
    "href" : "http://localhost:8080/acme-widget-hateoas-web-api/whatsits/1",
    "title" : "whatsit-0-0"
  }, {
    "rel" : "whatsit",
    "href" : "http://localhost:8080/acme-widget-hateoas-web-api/whatsits/2",
    "title" : "whatsit-0-1"
  } ]
}, {
  "links" : [ {
    "rel" : "self",
    "href" : "http://localhost:8080/acme-widget-hateoas-web-api/widgets/2"
  } ],
  "name" : "widget-1",
  "whatsitLinks" : [ {
    "rel" : "whatsit",
    "href" : "http://localhost:8080/acme-widget-hateoas-web-api/whatsits/3",
    "title" : "whatsit-1-0"
  }, {
    "rel" : "whatsit",
    "href" : "http://localhost:8080/acme-widget-hateoas-web-api/whatsits/4",
    "title" : "whatsit-1-1"
  } ]
}, {
  "links" : [ {
    "rel" : "self",
    "href" : "http://localhost:8080/acme-widget-hateoas-web-api/widgets/3"
  } ],
  "name" : "widget-2",
  "whatsitLinks" : [ {
    "rel" : "whatsit",
    "href" : "http://localhost:8080/acme-widget-hateoas-web-api/whatsits/5",
    "title" : "whatsit-2-0"
  }, {
    "rel" : "whatsit",
    "href" : "http://localhost:8080/acme-widget-hateoas-web-api/whatsits/6",
    "title" : "whatsit-2-1"
  } ]
} ]

[tony-kerz]

doh! forgot to run tests (and of course a bunch broke). looks like fixing all the tests will be enough work that i'm reluctant to do it if you are going to reject the change, but if this change to the Link class is acceptable, let me know and i'll fix tests. sorry about that 😢

[odrotbohm]

I think it makes sense to add the properties. However:

1. Please avoid moving methods around as this unnecessarily pollutes the changeset.
2. Please keep Link immutable, i.e. no setters, with… methods return new instances.

Thanks!

[gregturn]

Similar to #100

[pivotal-issuemaster]

@tony-kerz Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-issuemaster]

@tony-kerz Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[odrotbohm]

Fixed with #567.