Convert link with RFC5988 additional attributes #699
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the deserialization in the Jackson2HalModule was not working with the additional RFC5988 attributes added in PR #567 . This adds two tests for converting from Json.
Unfortunately, I am having trouble getting
media
to work. It does not seem to be converted properly using the json parser. I will continue looking into this, but would appreciate one of the maintainers looking it over.Also, note: I would use one constructor for the link in the deserialization, but it was mentioned in #567 to use Lambok notation. Currently, the constructor containing the attributes is protected and cannot be accessed from the Jackson2HalModule.