#678 - Add 'profile' to Link #679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregturn
force-pushed
the
feature/profile
branch
from
89fb2b8 to
363e691
Compare
gregturn
force-pushed
the
feature/profile
branch
from
363e691 to
7540e1b
Compare
|
@schauder You may additionally wish to start reading the HAL spec and RFC 5988 (both links provided in the commit message itself). |
Fully support HAL spec by adding "profile" as another optional attribute to `Link`. See: https://tools.ietf.org/html/draft-kelly-json-hal-08, https://tools.ietf.org/html/rfc5988
gregturn
force-pushed
the
feature/profile
branch
from
7540e1b to
3c5cc8a
Compare
Moved compilation of Regexp patterns out of methods in order to not repeat it over and over again. Applied soft assertions where multiple assertions where used where one failure didn't guarantee the failure of all other assertions. Minor formatting.
schauder
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully support HAL spec by adding "profile" as another optional attribute to
Link.