Skip to content

Add isFullyAuthenticated to AuthenticatedTrustResolver #11510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Jul 14, 2022 · 2 comments
Closed

Add isFullyAuthenticated to AuthenticatedTrustResolver #11510

jzheaux opened this issue Jul 14, 2022 · 2 comments
Assignees
@karthikeyan-r @jzheaux
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jul 14, 2022

Since isFullyAuthenticated is a composition of isAnonymous and isRememberMe, a default convenience method can be added:

default boolean isFullyAuthenticated(Authentication authentication) {
    return !isAnonymous(authentication) && !isRememberMe(authentication)
}

This would be nice for SecurityExpressionRoot#isFullyAuthenticated and AuthenticatedAuthorizationManager#fullyAuthenticated
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Jul 14, 2022
@karthikeyan-r
Copy link

Can i work on this implementation ?

@jzheaux
Copy link
Contributor Author

jzheaux commented Jul 22, 2022

Yep! The issue is yours.

@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Jul 22, 2022
karthikeyan-r pushed a commit to karthikeyan-r/spring-security that referenced this issue Jul 30, 2022
spring-projects#11510 - isFullyAuthenticated implementation
3988c52
@karthikeyan-r karthikeyan-r mentioned this issue Jul 30, 2022
Closed
karthikeyan-r pushed a commit to karthikeyan-r/spring-security that referenced this issue Sep 9, 2022
Add isFullyAuthenticated to AuthenticatedTrustResolver
8650131 
closes spring-projectsgh-11510
karthikeyan-r pushed a commit to karthikeyan-r/spring-security that referenced this issue Sep 26, 2022
Add isFullyAuthenticated to AuthenticatedAuthorizationManager
fbc4d75 
closes spring-projectsgh-11510
karthikeyan-r pushed a commit to karthikeyan-r/spring-security that referenced this issue Oct 13, 2022
Added null check for authentication object
2befb9a 
Closes spring-projectsgh-11510
jzheaux added a commit that referenced this issue Nov 29, 2022
@jzheaux
Polish JavaDoc
9bf2d3c 
- Replace ampersand
- Correct since version

Issue gh-11510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthikeyan-r karthikeyan-r

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karthikeyan-r @jzheaux