Skip to content

Add remaining methods from ExpressionUrlAuthorizationConfigurer to AuthorizeHttpRequestsConfigurer #11495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2022
Merged

Add remaining methods from ExpressionUrlAuthorizationConfigurer to AuthorizeHttpRequestsConfigurer #11495

merged 1 commit into from
Jul 14, 2022

Conversation

evgeniycheban
Copy link
Contributor

Add remaining methods from ExpressionUrlAuthorizationConfigurer to AuthorizeHttpRequestsConfigurer

  • Added fullyAuthenticated
  • Added rememberMe
  • Added anonymous

Closes gh-11360

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 12, 2022
@sjohnr sjohnr added status: duplicate A duplicate of another issue in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 13, 2022
@sjohnr sjohnr added this to the 5.8.0-M1 milestone Jul 13, 2022
@jzheaux
Copy link
Contributor

jzheaux commented Jul 13, 2022

Hi, @evgeniycheban. Before I review, do you intend to add permitAll and denyAll to AuthorizeHttpRequestsConfigurer in this PR?

@evgeniycheban
Copy link
Contributor Author

Hi, @jzheaux. The AuthorizeHttpRequestsConfigurer already has permitAll and denyAll methods.

@jzheaux
Copy link
Contributor

jzheaux commented Jul 14, 2022

Whoops, my bad. 😬 Thanks.

jzheaux
jzheaux requested changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeniycheban! I've left some feedback inline. Also, I think the formatting issue has been addressed, so please consider rebasing to simplify the PR.

@evgeniycheban
Add remaining methods from ExpressionUrlAuthorizationConfigurer to Au…
d6f5c6e 
…thorizeHttpRequestsConfigurer

- Added fullyAuthenticated
- Added rememberMe
- Added anonymous

Closes spring-projectsgh-11360
@evgeniycheban evgeniycheban requested a review from jzheaux July 14, 2022 17:11
@jzheaux jzheaux mentioned this pull request Jul 14, 2022
Closed
@jzheaux jzheaux merged commit 400cd60 into spring-projects:5.8.x Jul 14, 2022
@jzheaux
Copy link
Contributor

jzheaux commented Jul 14, 2022

Thanks, @evgeniycheban. This is now merged into 5.8.x. I also added a polish commit 5dff157 to update the formatting of the HttpSecurity blocks in the tests you added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.8.0-M1
Development

Successfully merging this pull request may close these issues.
4 participants
@evgeniycheban @jzheaux @sjohnr @spring-projects-issues