Skip to content

Add Authority String AuthorizationManager #12231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Nov 17, 2022 · 1 comment · Fixed by #12328
Closed

Add Authority String AuthorizationManager #12231

jzheaux opened this issue Nov 17, 2022 · 1 comment · Fixed by #12328
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Milestone
6.1.0-M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Nov 17, 2022 •
edited
Loading

It would be helpful to have an AuthorizationManager that takes the needed authorities as context.

Something like (pseudocode):

AuthorizationManager<Collection<String>> manager = (authentication, authorities) -> 
        (authentication hasAnyAuthority authorities) ? granted : denied;
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement labels Nov 17, 2022
@jzheaux jzheaux added this to the 6.1.0-M1 milestone Nov 17, 2022
@jzheaux jzheaux mentioned this issue Nov 17, 2022
Closed
@evgeniycheban evgeniycheban mentioned this issue Dec 2, 2022
Merged
evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Dec 2, 2022
@evgeniycheban
Add Authority String AuthorizationManager
3cb39c8 
Closes spring-projectsgh-12231
@evgeniycheban
Copy link
Contributor

Hi, @jzheaux I created a PR that adds this new AuthorizationManager and refactors the existing AuthorityAuthorizationManager to use it internally.

jzheaux pushed a commit that referenced this issue Dec 2, 2022
@evgeniycheban @jzheaux
Add Authority String AuthorizationManager
855282a 
Closes gh-12231
evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Jan 4, 2023
@evgeniycheban
Polish spring-projectsgh-12231
153e02b 
- Update copyright header
- Use Set.of instead of HashSet in AuthorityAuthorizationManager
- Align roleHierarchy test name with other tests in AuthoritiesAuthorizationManagerTests
jzheaux pushed a commit that referenced this issue Jan 5, 2023
@evgeniycheban @jzheaux
Polish gh-12231
1bbbd04 
- Update copyright header
- Use Set.of instead of HashSet in AuthorityAuthorizationManager
- Align roleHierarchy test name with other tests in AuthoritiesAuthorizationManagerTests
@evgeniycheban evgeniycheban mentioned this issue Jan 8, 2023
Closed
@vrudas vrudas mentioned this issue Mar 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M1
Development

Successfully merging a pull request may close this issue.

Add Authority String AuthorizationManager evgeniycheban/spring-security
2 participants
@jzheaux @evgeniycheban