Skip to content

SecuredAuthorizationManager should cache annotation's value #12232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Nov 17, 2022 · 2 comments · Fixed by #12335
Closed

SecuredAuthorizationManager should cache annotation's value #12232

jzheaux opened this issue Nov 17, 2022 · 2 comments · Fixed by #12335
Assignees
@evgeniycheban
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Milestone
6.1.0-M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Nov 17, 2022

SecurityAuthorizationManager currently caches an AuthorizationManager per method/class pair.

The memory footprint this requires can be improved by instead caching the annotation's value and passing that into an instance of the class indicated in #12231.
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement labels Nov 17, 2022
@jzheaux jzheaux added this to the 6.1.0-M1 milestone Nov 17, 2022
@jzheaux jzheaux mentioned this issue Nov 17, 2022
Closed
@evgeniycheban
Copy link
Contributor

@jzheaux I can take this.

@evgeniycheban evgeniycheban mentioned this issue Dec 3, 2022
Merged
@evgeniycheban
Copy link
Contributor

Hi, @jzheaux I created a PR that brings changes for SecuredAuthorizationManager to use the new AuthorizationManager that was added earlier.

evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Jan 4, 2023
@evgeniycheban
SecuredAuthorizationManager should cache annotation's value
af743c8 
Closes spring-projectsgh-12232
jzheaux pushed a commit that referenced this issue Jan 5, 2023
@evgeniycheban @jzheaux
SecuredAuthorizationManager should cache annotation's value
e0d676c 
Closes gh-12232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evgeniycheban evgeniycheban

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M1
Development

Successfully merging a pull request may close this issue.

SecuredAuthorizationManager should cache annotation's value evgeniycheban/spring-security
2 participants
@jzheaux @evgeniycheban