-
Notifications
You must be signed in to change notification settings - Fork 6k
Introduce ReactiveJwtAuthenticationConverter #6273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ReactiveJwtAuthenticationConverter
Would you like a PR for this? |
Have I told you have lucky we are to have great contributors like you, @edeandrea? Yes, a PR would be much appreciated, thank you. I'm actually thinking that The reason for this is that the user already gets the default scope-extraction logic by using |
That would be fine if I wanted to completely alter the authorities, but what if I want to merge the default behavior with my own set of authorities (which is actually my use case for bringing this up in the first place). Then I'd have to re-write that default logic myself rather than just calling super. My thought would be to refactor I'll code it out & submit a PR so you can see. If we need to tweak from there we can. |
I opened #6277 for this. We can take the discussion over there if any re-factoring is needed. |
Some changes based on PR comments Fixes gh-6273
Rework the implementation so that it is clearer that authorities are derived from a single claim. Issue: gh-6273
Rework the implementation so that it is clearer that authorities are derived from a single claim. Issue: spring-projectsgh-6273
Users often need to consult external resources in a non-blocking way to collect granted authorities in Resource Server.
This is currently possible by implementing a
Converter<Jwt, ? extends Mono<? extends AbstractAuthenticationToken>>
.On the Servlet stack, this task can be accomplished more easily by extending
JwtAuthenticationConverter
:It would be nice to have the same simplicity on the reactive side:
The text was updated successfully, but these errors were encountered: