-
Notifications
You must be signed in to change notification settings - Fork 6k
Introduce ReactiveJwtAuthenticationConverter #6277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ringframework/security/oauth2/server/resource/authentication/JwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...ework/security/oauth2/server/resource/authentication/ReactiveJwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
I completed the proposed changes as well as rebased the branch into a single commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your hard work, @edeandrea! I think it's a great move to compose the Jwt
to Collection
conversion. I've left some feedback, let me know if you have questions.
...ework/security/oauth2/server/resource/authentication/ReactiveJwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...ework/security/oauth2/server/resource/authentication/ReactiveJwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...ework/security/oauth2/server/resource/authentication/ReactiveJwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...ework/security/oauth2/server/resource/authentication/ReactiveJwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...ework/security/oauth2/server/resource/authentication/ReactiveJwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...rg/springframework/security/oauth2/server/resource/authentication/JwtAuthorityConverter.java
Outdated
Show resolved
Hide resolved
...ringframework/security/oauth2/server/resource/authentication/JwtAuthenticationConverter.java
Show resolved
Hide resolved
...ringframework/security/oauth2/server/resource/authentication/JwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...ringframework/security/oauth2/server/resource/authentication/JwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...ecurity/oauth2/server/resource/authentication/ReactiveJwtAuthorityConverterAdapterTests.java
Outdated
Show resolved
Hide resolved
I've pushed changes based on comments above & rebased the branch. You'll notice that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, again, @edeandrea, this looks nice. I apologize, there are just two small items I missed in the last PR. I've left my feedback inline.
@rwinch, since this is a bit larger of a PR, please feel free to jump in with any other requests.
...ringframework/security/oauth2/server/resource/authentication/JwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...ringframework/security/oauth2/server/resource/authentication/JwtAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
Some changes based on PR comments Fixes gh-6273
Changes made & rebase done. |
Thanks for another PR, @edeandrea! This has been merged into |
Introduce an equivalent to
JwtAuthenticationConverter
on the reactive stack that users can override if they so choose.Fixes gh-6273