Skip to content

Introduce ReactiveJwtAuthenticationConverter #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Introduce ReactiveJwtAuthenticationConverter #6277

merged 1 commit into from
Dec 17, 2018

Conversation

edeandrea
Copy link
Contributor

Introduce an equivalent to JwtAuthenticationConverter on the reactive stack that users can override if they so choose.

Fixes gh-6273

@edeandrea
Copy link
Contributor Author

I completed the proposed changes as well as rebased the branch into a single commit.

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your hard work, @edeandrea! I think it's a great move to compose the Jwt to Collection conversion. I've left some feedback, let me know if you have questions.

@edeandrea
Copy link
Contributor Author

I've pushed changes based on comments above & rebased the branch. You'll notice that JwtAuthenticationConverterTests now has fewer tests. Since the concept of converting a Jwt to GrantedAuthorities was abstracted out, I moved the majority of specific conversion tests into JwtGrantedAuthoritiesConverterTests. JwtAuthenticationConverterTests & ReactiveJwtAuthenticationConverterTests now just has a single default test along with a test for when overriding the JwtGrantedAuthoritiesConverter. One of the comments above mentioned doing that for ReactiveJwtAuthenticationConverterTests and I applied that to JwtAuthenticationConverterTests as well. If you'd like me to copy those tests back into JwtAuthenticationConverterTests I can surely do that.

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, again, @edeandrea, this looks nice. I apologize, there are just two small items I missed in the last PR. I've left my feedback inline.

@rwinch, since this is a bit larger of a PR, please feel free to jump in with any other requests.

Some changes based on PR comments

Fixes gh-6273
@edeandrea
Copy link
Contributor Author

Changes made & rebase done.

@jzheaux jzheaux merged commit 0f7dff3 into spring-projects:master Dec 17, 2018
@jzheaux
Copy link
Contributor

jzheaux commented Dec 17, 2018

Thanks for another PR, @edeandrea! This has been merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants