Skip to content

JwtTimestampValidator should change maxClockSkew to clockSkew #6380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Jan 10, 2019 · 3 comments · Fixed by #6416
Closed

JwtTimestampValidator should change maxClockSkew to clockSkew #6380

jzheaux opened this issue Jan 10, 2019 · 3 comments · Fixed by #6416
Assignees
@jzheaux
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement
Milestone
5.2.0.M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jan 10, 2019

JwtTimestampValidator has a property called maxClockSkew.

Let's simplify this to clockSkew. We need to change the field name, the constructor parameter, and the error message in the constructor.
@jzheaux jzheaux added status: first-timers-only An issue that can only be worked on by brand new contributors in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement labels Jan 10, 2019
@ajavorskidev ajavorskidev mentioned this issue Jan 10, 2019
Closed
ajavorskidev added a commit to ajavorskidev/spring-security that referenced this issue Jan 11, 2019
@ajavorskidev
Update JwtTimestampValidator.java
627e817 
Changed MaxClockSkew variable to clockSkew to simplify the name.

Fixes spring-projectsgh-6380
@ajavorskidev ajavorskidev mentioned this issue Jan 11, 2019
Merged
@aotitoola
Copy link

Hello, @jzheaux can I work on this issue?

jzheaux pushed a commit that referenced this issue Jan 14, 2019
@ajavorskidev @jzheaux
Update JwtTimestampValidator.java
dd45a49 
Changed MaxClockSkew variable to clockSkew to simplify the name.

Fixes gh-6380
@jzheaux
Copy link
Contributor Author

jzheaux commented Jan 14, 2019

@darthCodr Thanks for your interest, but this was picked up already by @ajavorskidev. My apologies for not noting that in the ticket earlier when the PR was submitted.

@aotitoola
Copy link

@jzheaux It's fine. I will wait for the next one. Thanks.

@jzheaux jzheaux self-assigned this Aug 5, 2020
@jzheaux jzheaux added this to the 5.2.0.M1 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M1
Development

Successfully merging a pull request may close this issue.

Update JwtTimestampValidator.java ajavorskidev/spring-security
Update JwtTimestampValidator.java
2 participants
@jzheaux @aotitoola