Skip to content

Update JwtTimestampValidator.java #6393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Update JwtTimestampValidator.java #6393

wants to merge 7 commits into from

Conversation

ajavorskidev
Copy link
Contributor

@ajavorskidev ajavorskidev commented Jan 10, 2019

Changed maxClockSkew to clockSkew in the file JwtTimestampValidator.java

Just simplified the MaxClockSkew to clockSkew regarding the issue
Fixes: gh-6380

Changed maxClockSkew to to clockSkew in the file JwtTimestampValidator.java
@jzheaux
Copy link
Contributor

jzheaux commented Jan 10, 2019

Thanks for the PR, @ajavorskidev!

Will you please adjust the commit message so that it contains the ticket that is fixed? You can see an example in the contribution guidelines

Changed the variable MaxClockSkew to clockSkew to simplify the name.

fixes gh-6380
@ajavorskidev
Copy link
Contributor Author

Have just created a new commit and added the ticket it fixes!

@jzheaux
Copy link
Contributor

jzheaux commented Jan 11, 2019

Nice, @ajavorskidev, thank you. Last step, will you please squash your commits?

@ajavorskidev
Copy link
Contributor Author

I'm having a bit of trouble squashing the commits together! After I save the rebase, how do I push the edit?

@ajavorskidev
Copy link
Contributor Author

Im just going to close this pull request and try again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JwtTimestampValidator should change maxClockSkew to clockSkew
2 participants