-
Notifications
You must be signed in to change notification settings - Fork 6k
Add support for HeaderWriterFilter to write headers at the beginning of the request #6501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
I would like to take this one. |
It's yours, @ankurpathak! |
Pull request for the issue: |
ankurpathak
added a commit
to ankurpathak/spring-security
that referenced
this issue
Feb 13, 2019
Add support for HeaderWriterFilter to write headers at the beginning of the request Fixes: spring-projectsgh-6501
jzheaux
added a commit
that referenced
this issue
Feb 18, 2019
In the Java config tests, there is a simplified way to configure Spring, and that is with SpringTestRule. Also, test names typically follow the when-then convention. Issue: gh-6501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Related to #6414
Let's add some support to
HeaderWriterFilter
for writing headers at the beginning of the request:Which would then allow folks to post process the
HeaderWriterFilter
and configure it:HeaderWriterFilter
writes headers at the end of the request. However, headers cannot be written after an include.If the user uses
servletContext.getRequestDispatcher(path).include(request, response)
, for example, then the security headers will not get written.Spring Security is able to wrap
HttpServletRequest
so thatrequest.getRequestDispatcher(path).include(request, response)
is captured, but it is not possible to do the same withServletContext
.The text was updated successfully, but these errors were encountered: