HeaderWriterFilter writes headers at beginning #6509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jzheaux I am not getting any Idea for tests. Please give some idea how I can write test. |
jzheaux
requested changes
Feb 7, 2019
There was a problem hiding this comment.
Thanks, again, @ankurpathak! I've left some feedback inline.
web/src/main/java/org/springframework/security/web/header/HeaderWriterFilter.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/springframework/security/web/header/HeaderWriterFilter.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/springframework/security/web/header/HeaderWriterFilter.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/springframework/security/web/header/HeaderWriterFilter.java
Show resolved
Hide resolved
ankurpathak
force-pushed
the
gh-6501-fix
branch
from
9b02d1b to
0d805ba
Compare
jzheaux
requested changes
Feb 11, 2019
| @@ -565,4 +567,20 @@ class HeadersConfigurerTests extends BaseSpringSpec { | |||
| responseHeaders == ['Strict-Transport-Security': 'max-age=31536000 ; includeSubDomains ; preload'] | |||
| } | |||
|
|
|||
| def "headers written at beginning of request"() { | |||
There was a problem hiding this comment.
Please make this a Java test. We are in the process of coverting the Groovy tests over to Java, so we don't want to make more work for ourselves.
...ork/security/config/annotation/authentication/configurers/HeadersConfigurerTestsConfigs.java
Outdated
Show resolved
Hide resolved
ankurpathak
force-pushed
the
gh-6501-fix
branch
from
0d805ba to
691a4d9
Compare
Add support for HeaderWriterFilter to write headers at the beginning of the request Fixes: spring-projectsgh-6501
ankurpathak
force-pushed
the
gh-6501-fix
branch
from
691a4d9 to
150ff3e
Compare
|
@ankurpathak Thanks for the PR! This is now merged into Also, I added a polish commit of 2b960b0 for the Java Config test - please take a look at the commit message for future reference. |
jzheaux
added
status: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for HeaderWriterFilter to write headers at the beginning of the request
Fixes: gh-6501