Skip to content

Add ability to customize OAuth2AuthorizationRequestRedirectWebFilter in OAuth2LoginSpec #7466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rchigvintsev opened this issue Sep 23, 2019 · 0 comments
Closed

Add ability to customize OAuth2AuthorizationRequestRedirectWebFilter in OAuth2LoginSpec #7466

rchigvintsev opened this issue Sep 23, 2019 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.2.0

Comments

@rchigvintsev
Copy link
Contributor

It would be nice to be able to customize OAuth2AuthorizationRequestRedirectWebFilter during configuring of OAuth2 login in the following way: http.oauth2Login().authorizationRequestRepository(requestRepository) .

Also for now OAuth2AuthorizationRequestRedirectWebFilter creates its own instance of ServerRequestCache. I think common ServerRequestCache (that is configured using RequestCacheSpec) should be used in this case.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 23, 2019
rchigvintsev added a commit to rchigvintsev/spring-security that referenced this issue Sep 23, 2019
@rchigvintsev
Allow to customize OAuth2AuthorizationRequestRedirectWebFilter in OAu…
566a0aa 
…th2 login configuration

Fixes spring-projectsgh-7466
@rchigvintsev rchigvintsev mentioned this issue Sep 23, 2019
Closed
@jgrandja jgrandja self-assigned this Sep 26, 2019
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 26, 2019
@jgrandja jgrandja added this to the 5.2.0 milestone Sep 26, 2019
@jgrandja jgrandja changed the title Add ability to customize OAuth2AuthorizationRequestRedirectWebFilter when OAuth2 login is being configured Add ability to customize OAuth2AuthorizationRequestRedirectWebFilter in OAuth2LoginSpec Sep 26, 2019
jgrandja added a commit that referenced this issue Sep 27, 2019
@jgrandja
Polish gh-7466
08d2c93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0
3 participants
@rchigvintsev @jgrandja @spring-projects-issues