Skip to content

Allow to customize OAuth2AuthorizationRequestRedirectWebFilter in OAuth2LoginSpec #7467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rchigvintsev
Copy link
Contributor

Fixes gh-7466

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 23, 2019
@jgrandja jgrandja changed the title Allow to customize OAuth2AuthorizationRequestRedirectWebFilter in OAuth2 login configuration Allow to customize OAuth2AuthorizationRequestRedirectWebFilter in OAuth2LoginSpec Sep 26, 2019
@jgrandja jgrandja self-assigned this Sep 26, 2019
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 26, 2019
@jgrandja jgrandja added this to the 5.2.0 milestone Sep 26, 2019
@jgrandja
Copy link
Contributor

Thanks for the PR @rchigvintsev! This is now in master.

I went ahead and applied some polish given that our 5.2 GA is on Monday.
Typically we would have gone through a review process where I would have requested changes from you but there is no time at this point. Feel free to check the polish commit 08d2c93 and let me know if you have any questions.
Thanks again.

@jgrandja jgrandja closed this Sep 27, 2019
@rchigvintsev
Copy link
Contributor Author

@jgrandja I couldn't decide how to write the tests and where to place them for quite a long time. :) Thank you for polishing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to customize OAuth2AuthorizationRequestRedirectWebFilter in OAuth2LoginSpec
3 participants