-
Notifications
You must be signed in to change notification settings - Fork 6k
DefaultAuthenticationEventPublisher should be configurable via Map #7824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @jzheaux, can I take this one? Can you give me the 'how to' link? Thanks |
Sure, @akuma8, happy to help. What do you mean by "how to" link? The contribution guide is good to read before getting started with code changes. |
@zeeshanadnan There are other kind of issues here https://github.com/spring-projects/spring-security/issues?q=is%3Aissue+is%3Aopen+label%3A%22status%3A+first-timers-only%22 |
@zeeshanadnan thanks for reaching out - I think that @akuma8 is working on this one. (I see you found another ticket, too, which is great!) |
Fixed checkstyle violation Issue gh-7824
DefaultAuthenticationEventPublisher
can be configured with additional exception mappings viasetAdditionalExceptionMappings(Properties)
.It would be nice to overload this method to take a
Map
instead of aProperties
object sinceMap
is an interface and is more widely used.To complete this ticket requires two steps, then:
setAdditionalExceptionMappings(Map)
method, e.g.:which loops through the
Map
in a similar way to how the existing method loops through theProperties
object.We need to add tests that ensure that the class acts appropriately if invalid values are passed into that method, e.g. a
null
map. We also need to test this method's happy path.The text was updated successfully, but these errors were encountered: