Skip to content

DefaultAuthenticationEventPublisher is now configurable via a Map #7925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DefaultAuthenticationEventPublisher is now configurable via a Map #7925

wants to merge 1 commit into from

Conversation

akuma8
Copy link
Contributor

@akuma8 akuma8 commented Feb 4, 2020 •
edited
Loading

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 4, 2020
@akuma8 akuma8 changed the title DefaultAuthenticationEventPublisher is now configurablAe via a Map DefaultAuthenticationEventPublisher is now configurable via a Map Feb 4, 2020
@akuma8 akuma8 requested a review from jzheaux February 5, 2020 10:29
@jzheaux jzheaux self-assigned this Feb 5, 2020
@jzheaux jzheaux added in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 5, 2020
@jzheaux jzheaux added this to the 5.3.0 milestone Feb 5, 2020
jzheaux
jzheaux requested changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @akuma8! Thanks for the PR. I've left some feedback inline.

@akuma8
Copy link
Contributor Author

akuma8 commented Feb 10, 2020

@jzheaux Thank you for your comments. I solved them. Let me know if there are other changes to do.
Sorry for the late feedback. I am sick :(

@jzheaux
Copy link
Contributor

jzheaux commented Feb 20, 2020

@akuma8 sorry that you were sick, I hope that you are feeling better now. Thank you for the updates.

Let's please do two more changes:

  • First, will you please rebase your branch to resolve the conflict in the PR?
  • Second, will you please deprecate the old Properties method? This is a suggestion that @jgrandja made to me offline; my apologies that it wasn't in my initial review. To deprecate a method, please add both the @Deprecated annotation to the method and the @deprecated JavaDoc tag that includes instructions to use the new Map method you've created.

@akuma8
Copy link
Contributor Author

akuma8 commented Feb 21, 2020

@jzheaux Yes I am feeling better now, thanks.
I did the suggested changes, please let me know if there are other changes.

@jzheaux
Copy link
Contributor

jzheaux commented Feb 21, 2020

@akuma8 thanks again! This is now merged into master via bfc2832

Note that I polished the commit message to meet our guidelines. I also fixed a checkstyle violation in 1b68cdb.

I'm looking forward to future contributions from you!

@jzheaux jzheaux closed this Feb 21, 2020
@akuma8
Copy link
Contributor Author

akuma8 commented Feb 24, 2020

@jzheaux thanks for the merge.
Please let me know if you have possible issues for me. I think the more I contribute the better I will understand Spring security and pay more attention to the contribution guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux requested changes

Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@akuma8 @jzheaux @spring-projects-issues