-
Notifications
You must be signed in to change notification settings - Fork 6k
Implement providing a custom AuthoritiesPopulator in ADLdapAuthProvider #14539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @Haarolean! I've left some feedback inline.
...ringframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...ringframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...ringframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...ingframework/security/ldap/authentication/ad/DefaultActiveDirectoryAuthoritiesPopulator.java
Outdated
Show resolved
Hide resolved
...ingframework/security/ldap/authentication/ad/DefaultActiveDirectoryAuthoritiesPopulator.java
Outdated
Show resolved
Hide resolved
...ingframework/security/ldap/authentication/ad/DefaultActiveDirectoryAuthoritiesPopulator.java
Outdated
Show resolved
Hide resolved
...ingframework/security/ldap/authentication/ad/DefaultActiveDirectoryAuthoritiesPopulator.java
Outdated
Show resolved
Hide resolved
...ringframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
@Haarolean, just one more thing, if you would please run:
Then it will ensure that the code is following all of Spring Security's formatting standards. Thank you. |
Thanks, I've done |
Thanks, @Haarolean! This is now merged into |
Implemented a possibility to provide a custom
AuthoritiesPopulator
inActiveDirectoryLdapAuthenticationProvider
Discussed in #4490
loadUserAuthorities
into a separate default AD populator, the same way it's done for non-AD LDAP AuthenticationProvider. Replaced a for with streams when collecting authorities;Resolves #4490