Add Reactive Clear-Site-Data Support #6777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sayembd
commented
Apr 14, 2019
sayembd
commented
- A new implementation of ServerHttpHeadersWriter has been created to add Clear-Site-Data header support.
- A new implementation of ServerLogoutHandler has been created which can be configured to write response headers during logout.
- Added unit tests for both implementations.
rhamedy
reviewed
Apr 14, 2019
...ringframework/security/web/server/authentication/logout/HeaderWriterServerLogoutHandler.java
Outdated
Show resolved
Hide resolved
jzheaux
requested changes
Apr 18, 2019
...ramework/security/web/server/authentication/logout/HeaderWriterServerLogoutHandlerTests.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/security/web/server/header/ClearSiteDataServerHttpHeadersWriter.java
Outdated
Show resolved
Hide resolved
1. A new implementation of ServerHttpHeadersWriter has been created to add Clear-Site-Data header support. 2. A new implementation of ServerLogoutHandler has been created which can be configured to write response headers during logout. 3. Added unit tests for both implementations. Fixes spring-projectsgh-6743
|
@jzheaux Thank you very much for the review! I've made the necessary adjustments and pushed the changes. |
jzheaux
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.