Rename getRequestedSessionId -> getRequestedSessionIds #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the method signature at HttpSessionStrategy is getRequestedSessionId. Now, has been renamed to getRequestedSessionIds in order to store all the session ids present in the request. Fixes spring-projectsgh-362
|
Wouldn't this be a breaking change to a public API? I know I have my own custom implementation of HttpSessionStrategy and upgrading to a version of spring-session which contains this change would break my code as well as break anyone else's code that is either extending or using the public API. |
|
@edeandrea yes, this will break your code. That's the reason why this is schedule for version 2.0 because it will be a major release. |
|
Got it - thanks! |
vpavic
added
status: duplicate
|
@eddumelendez Thanks for the PR, we are addressing this in a bit different way as a part of #906. |
vpavic
removed
status: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the method signature at HttpSessionStrategy is
getRequestedSessionId. Now, has been renamed to getRequestedSessionIds
in order to store all the session ids present in the request.
Fixes gh-362