Skip to content

HttpSessionStrategy getRequestedSessionId->getRequestedSessionIds #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwinch opened this issue Feb 11, 2016 · 0 comments
Closed

HttpSessionStrategy getRequestedSessionId->getRequestedSessionIds #362

rwinch opened this issue Feb 11, 2016 · 0 comments
Assignees
Labels
in: core type: breaks-passivity This issue breaks passivity type: enhancement A general enhancement
Milestone

Comments

@rwinch
Copy link
Member

rwinch commented Feb 11, 2016

Previously HttpSessionStrategy contained a flaw in that it only allowed resolving a single session id. However, it is common for multiple session ids to be present in the request. For example, when using cookies the same cookie name may be present for multiple domains or multiple paths.

This commit changes HttpSessionStrategy from:

String getRequestedSessionId();

to

List<String> getRequestedSessionIds();

This means that implementations of HttpSessionStrategy should change from
something like:

public String getRequestedSessionId() {
   ...
   return result;
}

to

public List<String> getRequestedSessionIds() {
    ...
    return result == null ? 
        Collections.<String>emptyList() : Collections.singleton(result);
}
@rwinch rwinch added type: enhancement A general enhancement in: core type: breaks-passivity This issue breaks passivity labels Feb 11, 2016
@rwinch rwinch self-assigned this Feb 11, 2016
@rwinch rwinch added this to the 1.1.0 RC1 milestone Feb 11, 2016
@rwinch rwinch modified the milestones: 1.2.0 M1, 1.1.0 RC1 Feb 11, 2016
@rwinch rwinch modified the milestones: 2.0 M1, 1.3.0 M1 Sep 8, 2016
eddumelendez added a commit to eddumelendez/spring-session that referenced this issue Sep 8, 2016
Currently the method signature at HttpSessionStrategy is
getRequestedSessionId. Now, has been renamed to getRequestedSessionIds
in order to store all the session ids present in the request.

Fixes spring-projectsgh-362
@rwinch rwinch modified the milestones: 2.0.0 M1, 2.0.0.M2 May 10, 2017
@rwinch rwinch modified the milestones: 2.0.0.M2, 2.0.0.M3 Jun 16, 2017
@rwinch rwinch modified the milestones: 2.0.0.M3, 2.0.0.M4 Jul 21, 2017
@rwinch rwinch modified the milestones: 2.0.0.M4, 2.0.0.M5 Sep 13, 2017
@rwinch rwinch modified the milestones: 2.0.0.M5, 2.0.0.RC1 Oct 3, 2017
@vpavic vpavic assigned vpavic and unassigned rwinch Oct 25, 2017
vpavic added a commit to vpavic/spring-session that referenced this issue Oct 25, 2017
This commit simplifies `HttpSessionStrategy` API by aligning it with Spring Framework's `WebSessionIdResolver`. As a part of this, support for managing multiple users' sessions has been removed.

Closes spring-projectsgh-275
Closes spring-projectsgh-362
vpavic added a commit to vpavic/spring-session that referenced this issue Oct 26, 2017
This commit simplifies `HttpSessionStrategy` API by aligning it with Spring Framework's `WebSessionIdResolver`. As a part of this, support for managing multiple users' sessions has been removed.

Closes spring-projectsgh-275
Closes spring-projectsgh-362
@rwinch rwinch closed this as completed in cd394bb Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: breaks-passivity This issue breaks passivity type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants