-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CookieHttpSessionStrategy should look at all cookies not just the first #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
eddumelendez
added a commit
to eddumelendez/spring-session
that referenced
this issue
Apr 27, 2016
Previous to this commit, just the first cookie is considered. Now, all cookies are considered to look for SESSION cookie. See spring-projectsgh-275
1 task
eddumelendez
added a commit
to eddumelendez/spring-session
that referenced
this issue
Oct 4, 2016
Previous to this commit, just the first cookie is considered. Now, all cookies are considered to look for SESSION cookie. See spring-projectsgh-275
vpavic
added a commit
to vpavic/spring-session
that referenced
this issue
Oct 25, 2017
This commit simplifies `HttpSessionStrategy` API by aligning it with Spring Framework's `WebSessionIdResolver`. As a part of this, support for managing multiple users' sessions has been removed. Closes spring-projectsgh-275 Closes spring-projectsgh-362
vpavic
added a commit
to vpavic/spring-session
that referenced
this issue
Oct 26, 2017
This commit simplifies `HttpSessionStrategy` API by aligning it with Spring Framework's `WebSessionIdResolver`. As a part of this, support for managing multiple users' sessions has been removed. Closes spring-projectsgh-275 Closes spring-projectsgh-362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now if multiple cookies are submitted to Spring Session, it only considers the first cookie with the correct name. We should inspect additional cookies if the session id in the first cookie was not valid.
We need to select the first session id that is valid for this application. So for example, if a request to
/other/
is madeThen a request to
/
is madeFinally another request to
/other/
is made in which both SESSION cookies are submitted with the request:If these two sessions are for different applications, then we must select the correct session id. Note that the client will not include the path information in the request (it is only in the response).
We must also consider a similar scenario for the domain.
Part of the struggle with this is how to make the changes passive (or as passive as possible) without looking up the session multiple times.
Relates to gh-362
The text was updated successfully, but these errors were encountered: