Look at all cookies instead just the first #645
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this commit, just the first cookie is considered. Now, all cookies are considered to look for SESSION cookie. See spring-projectsgh-275
|
I'm really interested in getting this merged as it's currently holding me back from using spring-session in my project. Is anyone able to take a look at this and consider if it is mergeable? |
|
@oatesp We are currently working on a broader refactoring of Also note that this PR by itself does not address the original issue since the resolved session id's are not actually validated against the session store. |
|
@eddumelendez Thanks for the PR, we are addressing this in a bit different way as explained in the comment above. |
vpavic
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit, just the first cookie is considered. Now, all
cookies are considered to look for SESSION cookie.
See gh-275
Initial draft