Skip to content

CC-37354 Glue RestAPI Migration Phase 1/2#3590

Open
stereomon wants to merge 24 commits intomasterfrom
feature/cc-37354/master-glue-rest-api-migration-phase-1
Open

CC-37354 Glue RestAPI Migration Phase 1/2#3590
stereomon wants to merge 24 commits intomasterfrom
feature/cc-37354/master-glue-rest-api-migration-phase-1

Conversation

@stereomon
Copy link
Copy Markdown
Contributor

@stereomon stereomon commented Mar 31, 2026

PR Description

Migration guides for: https://release.spryker.com/release-groups/view/6425

Tickets

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md
  • I validated and improved the content with Custom GPT
  • I checked my pages at the deployment preview website.
  • I invited a person to review and merge this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 31, 2026

Deploy Preview for spryker-docs ready!

Name Link
🔨 Latest commit c4a4df1
🔍 Latest deploy log https://app.netlify.com/projects/spryker-docs/deploys/69e5df0f599c7c000812bfed
😎 Deploy Preview https://deploy-preview-3590--spryker-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@stereomon stereomon changed the title Feature/cc 37354/master glue rest api migration phase 1 CC-37354 Glue RestAPI Migration Phase 1/2 Apr 16, 2026
@profuel profuel self-requested a review April 17, 2026 08:59
Comment thread .claude/skills/review/SKILL.md Outdated
Comment thread .claude/skills/review/SKILL.md Outdated
Comment thread .claude/skills/review/SKILL.md Outdated
Comment thread .claude/skills/review/SKILL.md Outdated
Comment thread .claude/skills/review/SKILL.md
Comment thread .claude/skills/review/SKILL.md Outdated
Comment thread docs/dg/dev/architecture/api-platform/enablement.md
Comment thread docs/dg/dev/architecture/api-platform/enablement.md
link: docs/dg/dev/architecture/api-platform/troubleshooting.html
---

API Platform automatically converts all exceptions into JSON:API formatted error responses. This includes domain errors thrown by Providers and Processors, validation failures, authentication errors, and unexpected exceptions.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see example of the unexpected exceptions.
My main concern - how to avoid leak of internal error messages?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see example of the unexpected exceptions.

Unexpected can be anything. What should be used as an example here?

API Platform handles also exception as described here https://api-platform.com/docs/core/errors/

We also have our own subscriber for certain exceptions but in general there should be no internal excption message leaking.

}
```

`AbstractRelationshipResolver` provides the following helpers:
Copy link
Copy Markdown
Collaborator

@profuel profuel Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about merchant, agent, user.
I'm not 100% sure how you built the initial list, I did my best guess.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't share all of them with the outside by default. The ones listed here are system defaults.

stereomon and others added 6 commits April 20, 2026 10:02
Co-authored-by: Andrey Tkachenko <andrey.tkachenko@spryker.com>
Co-authored-by: Andrey Tkachenko <andrey.tkachenko@spryker.com>
Co-authored-by: Andrey Tkachenko <andrey.tkachenko@spryker.com>
Co-authored-by: Andrey Tkachenko <andrey.tkachenko@spryker.com>
Co-authored-by: Andrey Tkachenko <andrey.tkachenko@spryker.com>
Co-authored-by: Andrey Tkachenko <andrey.tkachenko@spryker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants