-
Notifications
You must be signed in to change notification settings - Fork 103
CC-37354 Glue RestAPI Migration Phase 1/2 #3590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stereomon
wants to merge
24
commits into
master
Choose a base branch
from
feature/cc-37354/master-glue-rest-api-migration-phase-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4437ef6
Added Serializer Guidelines.
stereomon 36d1e0e
Updated docs
stereomon 087ce8a
Merge branch 'master' of github.com:spryker/spryker-docs into feature…
stereomon 3377b64
CC-37354 Initial Migration guide for API Platform.
stereomon 5a88332
CC-37354 Fixed CI.
stereomon 0c10206
CC-337354 Added migration guides.
stereomon 3107cf8
Merge branch 'master' of github.com:spryker/spryker-docs into feature…
stereomon 3cc48f1
CC-37354 Updated docs.
stereomon 867ff4e
CC-373543 Merged master
stereomon d095e38
CC-37354 Added migration guides.
stereomon 245add2
Merge branch 'master' of github.com:spryker/spryker-docs into feature…
stereomon 00bddde
CC-37354 Fixed CI issues.
stereomon e8fd873
Merge branch 'master' of github.com:spryker/spryker-docs into feature…
stereomon 362ed8d
CC-37354 Removed review markdown
stereomon 596cdb4
Merge branch 'master' of github.com:spryker/spryker-docs into feature…
stereomon 9307a0b
CC-37354 Added docs for cross-cutting project refactoing documentatio…
stereomon 109ff65
Merge branch 'master' of github.com:spryker/spryker-docs into feature…
stereomon 01f8034
CC-37354 Added note to skill about it's removal.
stereomon 7615b5b
Update .claude/skills/review/SKILL.md
stereomon 5f48e4a
Update .claude/skills/review/SKILL.md
stereomon 50b263f
Update .claude/skills/review/SKILL.md
stereomon 7d5cffc
Update .claude/skills/review/SKILL.md
stereomon 15e2ba6
Update .claude/skills/review/SKILL.md
stereomon c4a4df1
Update .claude/skills/review/SKILL.md
stereomon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| --- | ||
| name: review | ||
| description: Run detailed review of the docs changes against the code changes made in suite. | ||
| --- | ||
|
|
||
| > **Note:** This skill will be removed after all migrations have been completed and documented. | ||
|
|
||
| Review my migration documentation changes with extreme scrutiny. The goal is to catch every issue before customers do. | ||
|
|
||
| ## What to do | ||
|
|
||
| 1. Get the changed files in this docs branch vs master (`git diff master..HEAD --name-only`). | ||
| 2. Get the changed files in the suite repo on the same-named branch vs master as the user for a path if not added as dir. | ||
| 3. Do not trust the docs — trust the code. | ||
| 4. For every doc change, validate it line-by-line against the actual suite code diff. Every plugin name, every FQCN, every namespace, every method name must match the code exactly. | ||
| 5. Console commands in the docs MUST be verified against the suite repo. Check `config/install/docker.yml`, `.github/workflows/ci.yml`, and the actual entrypoints (`vendor/bin/glue` vs `vendor/bin/console`). ``` | ||
|
|
||
| ## Mandatory rules — flag violations as errors | ||
|
|
||
| 1. Migration guides focus on what to change. | ||
| 2. **No Verification sections on per-module migration pages.** Remove curl examples, "how to test", "verify that X works". Projects have their own test harness. | ||
|
|
||
| 2. **Cross-cutting must be truly cross-cutting.** A change belongs in cross-cutting ONLY if it is required regardless of which module you migrate first. If it is triggered by migrating a specific module, it belongs in that module's guide — even if it touches a shared file like OauthDependencyProvider or AuthenticationDependencyProvider. Flag any module-specific change sitting in the cross-cutting section. | ||
|
|
||
| 3. **Console commands must use the correct entrypoint.** | ||
| - API Platform commands: `docker/sdk cli glue api:generate`, NOT `docker/sdk cli console api:generate` | ||
| - Glue cache: `docker/sdk cli glue cache:clear`, NOT `docker/sdk cli console cache:clear` | ||
| - Env var: `GLUE_APPLICATION=GLUE_STOREFRONT` (all caps), never `storefront` (any case is wrong in this context) | ||
| - The standard post-migration block is: | ||
| ``` | ||
| docker/sdk cli console transfer:generate | ||
| docker/sdk cli glue api:generate | ||
| docker/sdk cli glue cache:clear | ||
| ``` | ||
|
|
||
| 4. **"Create" vs "update" — say what the code actually does.** If the suite diff shows a new file, the doc must say "create". If it shows a modified file, say "update" or "replace the import". Saying "update" when the file is brand new is wrong. | ||
|
|
||
| 5. **Relationship plugins — track what stays.** Do not only document removals. Explicitly list plugins that MUST NOT be removed yet because their dependent module has not been migrated. Every migration guide needs a relationship status table. | ||
|
|
||
| 6. **Internal links must start with `/` and end with `.html`.** This applies to both inline markdown links AND frontmatter `related:` entries. | ||
|
|
||
| 7. **`last_updated` must be today's date** for every file touched in this PR. | ||
|
|
||
| 8. **Do not bleed scope.** If a shared dependency provider (e.g., Checkout) has plugins from 5 different modules, only document the plugins relevant to the module being migrated. The rest belongs in their own guides. | ||
|
|
||
| 9. **FQCNs must be verified against the suite code.** Do not assume the doc has the right namespace — grep the suite repo for every class name mentioned. | ||
|
|
||
| 10. **Version placeholders `^X.Y.Z` are acceptable** — do not flag these. | ||
|
|
||
| ## How to report | ||
|
|
||
| For every issue found, report: | ||
| - Filename from the project's root and line number, colon separator | ||
| - What is wrong (quote the offending text) | ||
| - What the code actually shows | ||
| - Concrete fix | ||
|
|
||
| Be adversarial. Assume every line has a mistake until proven otherwise. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.