Skip to content

Deploy userinfofetcher regorules #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 77 commits into from
Aug 6, 2024
Merged

Deploy userinfofetcher regorules #580

merged 77 commits into from
Aug 6, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented May 29, 2024

Description

Fixes #558 by always including static rules with the bundle builder. Builds on top of #578, and should not be merged before that is.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

nightkr and others added 30 commits April 12, 2023 11:31
@nightkr
Add group fetcher container
455bdc4
@nightkr
Spike group fetcher functionality
63ee375
@nightkr
Rename group fetcher to user info fetcher
bca2d62
@nightkr
Generalize enrichment endpoints to have room for arbitrary user info
9c1098c
@nightkr
Expose user roles
8b28fd4
@nightkr
Make UIF configurable
a5bbe88
@nightkr
Make UIF credentials configurable too
08823b7
@nightkr
OPA 0.45 -> 0.51
412e542
@nightkr
Broke out UIF into its own crate
22507d0
@nightkr
UIF error handling
cffa188
@nightkr
Ingest custom attributes
c74b6d9
@nightkr
Shut down on SIGTERM
1ef78e8
@nightkr
Split keycloak backend out into separate module
67e411f
@nightkr
Fix UIF startup when using none backend
eb134b7
@nightkr
Rename GroupMembershipRequest to UserInfoRequest
fb6da54
@nightkr
Cache fetched UserInfo
f298e0b
@nightkr
Merge branch 'main' into spike/user-info-fetcher
b1644e4
@nightkr
Switch UIF to also use workspace dependencies
3d160ca
@nightkr
Configurable UIF cache ttl
a4f495d
@nightkr
UIF crate metadata
57b45c7
@nightkr
Move userInfo rule into helm chart
20e585c
@nightkr
Turn UIF custom attributes into a multidict
05df3cb
@nightkr
UIF smoke test
2c511e4
@nightkr
Remove rules from Helm chart until we have a better way to deploy them
23a55c6
@nightkr
Lint-b-gone
8c45dc1
@nightkr
Update CRD
0cdbfd3
@nightkr
UIF readme
fc7de76
@nightkr
SNAFU error for UIF config
0a684d9
@nightkr
Revert Cmd wrapper enum
3aceb68
@nightkr
docs
65934ee
Base automatically changed from spike/bundle-builder-v2 to main July 31, 2024 12:53
@nightkr nightkr dismissed NickLarsenNZ’s stale review July 31, 2024 12:53

The base branch was changed.

@nightkr nightkr marked this pull request as ready for review July 31, 2024 13:22
@nightkr nightkr requested a review from a team July 31, 2024 13:23
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr requested a review from NickLarsenNZ August 1, 2024 11:08
sbernauer
sbernauer requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@nightkr nightkr requested a review from sbernauer August 6, 2024 15:06
sbernauer
sbernauer approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nightkr nightkr added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit d27ba87 Aug 6, 2024
31 checks passed
@nightkr nightkr deleted the spike/userinfofetcher-regorules branch August 6, 2024 15:47
@sbernauer sbernauer mentioned this pull request Aug 7, 2024
Closed
NickLarsenNZ added a commit that referenced this pull request Aug 13, 2024
@NickLarsenNZ
fix(kuttl): revert change from #580
cd3c31e
@NickLarsenNZ NickLarsenNZ mentioned this pull request Aug 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 14, 2024
@NickLarsenNZ
fix(kuttl tests): Use bundled userinfo rego utility (#619)
eb88fcf 
* test(kuttl): improve error output in python scripts

* chore(kuttl): ruff formatting

* chore(kuttl): improve error output in python scripts

* fix(kuttl): revert change from #580

* fix(kuttl): use bundled userinfo code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@NickLarsenNZ NickLarsenNZ Awaiting requested review from NickLarsenNZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy wrapper RegoRules for the UserInfoFetcher
3 participants
@nightkr @NickLarsenNZ @sbernauer