Skip to content

Deploy userinfofetcher regorules #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 77 commits into from
Aug 6, 2024
Merged

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented May 29, 2024

Description

Fixes #558 by always including static rules with the bundle builder. Builds on top of #578, and should not be merged before that is.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

Base automatically changed from spike/bundle-builder-v2 to main July 31, 2024 12:53
@nightkr nightkr dismissed NickLarsenNZ’s stale review July 31, 2024 12:53

The base branch was changed.

@nightkr nightkr marked this pull request as ready for review July 31, 2024 13:22
@nightkr nightkr requested a review from a team July 31, 2024 13:23
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 1, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@nightkr nightkr requested a review from sbernauer August 6, 2024 15:06
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nightkr nightkr added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit d27ba87 Aug 6, 2024
31 checks passed
@nightkr nightkr deleted the spike/userinfofetcher-regorules branch August 6, 2024 15:47
NickLarsenNZ added a commit that referenced this pull request Aug 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 14, 2024
* test(kuttl): improve error output in python scripts

* chore(kuttl): ruff formatting

* chore(kuttl): improve error output in python scripts

* fix(kuttl): revert change from #580

* fix(kuttl): use bundled userinfo code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy wrapper RegoRules for the UserInfoFetcher
3 participants