Skip to content

fix(kuttl tests): Use bundled userinfo rego utility #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Aug 9, 2024

Fixes the test failures (see slack thread):

The effective fixes were cd3c31e and 7c308cc

Traceback (most recent call last):
  File "/tmp/test-regorule.py", line 60, in <module>
    raise e
  File "/tmp/test-regorule.py", line 50, in <module>
something went wrong. last response: {'result': {}}
    assertions(username, response, 
  • Use the bundled userinfo rego utility (partially reverts Deploy userinfofetcher regorules #580)
  • Improve the output of the test scripts
    • print out the exception, it will have more information (from the assertions() function).
    • ruff formatting

@NickLarsenNZ NickLarsenNZ self-assigned this Aug 9, 2024
@NickLarsenNZ NickLarsenNZ changed the title test(kuttl): Improve error output in python scripts fix(kuttl): Use bundled userinfo rego Aug 13, 2024
@NickLarsenNZ NickLarsenNZ changed the title fix(kuttl): Use bundled userinfo rego fix(kuttl): Use bundled userinfo rego utility Aug 13, 2024
@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Aug 13, 2024

Kuttl tests now pass:

--- PASS: kuttl (68.66s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/keycloak-user-info_opa-latest-0.66.0_keycloak-23.0.1_openshift-false (68.65s)
        --- PASS: kuttl/harness/aas-user-info_opa-latest-0.66.0_openshift-false (32.08s)
PASS

@NickLarsenNZ NickLarsenNZ enabled auto-merge August 13, 2024 13:18
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!
LGTM as tests passed

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Aug 14, 2024
@sbernauer sbernauer removed this pull request from the merge queue due to a manual request Aug 14, 2024
@sbernauer
Copy link
Member

CC @nightkr, as you wrote the original test

@sbernauer sbernauer changed the title fix(kuttl): Use bundled userinfo rego utility fix(kuttl tests): Use bundled userinfo rego utility Aug 14, 2024
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit eb88fcf Aug 14, 2024
31 checks passed
@NickLarsenNZ NickLarsenNZ deleted the test/improve-error-output branch August 14, 2024 06:29
@nightkr
Copy link
Member

nightkr commented Aug 14, 2024

Yep, looks reasonable to me. Mea culpa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants