-
Notifications
You must be signed in to change notification settings - Fork 77
feat: add pagination to alerts and messages endpoints #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Modify the API to add pagination to those endpoints, to be able to render faster in the browser Closes: #1020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Copying this from Slack, so it doesn't get buried in discussion. In early testing, we all saw crashed in the frontend — our Table implementation expects that chat_id on each object in the list of messages is unique — I am seeing some duplication in the response, e.g.
|
* feat: filter messages by ID * lint fix * fix: use `.bindparams` for `filter_by_ids`
closed in favor of @alex-mcgovern PR |
Modify the API to add pagination to those endpoints, to be able to render faster in the browser
Closes: #1020