Skip to content

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

The existing logic doesn't really provide much additional value and does break google-ability.

For example, prophet has several reports about an error code 3221225657, which has basically 0 hits on google besides prophet's repo. That's because we're assuming the world is a unix system and subtracting 128. The real error is 3221225785, which has significantly more helpful results.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@syclik syclik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WardBrian WardBrian merged commit fb278ec into develop Sep 8, 2025
16 checks passed
@WardBrian WardBrian deleted the no-retcode-munging branch September 8, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants