Skip to content

Achievements: Fix counting progression achievements #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stenzek merged 1 commit into from
Aug 9, 2025
Merged

Achievements: Fix counting progression achievements #3503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions dep/rcheevos/src/rc_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,6 +933,11 @@ static void rc_client_subset_get_user_game_summary(const rc_client_subset_info_t
++summary->num_core_achievements;
summary->points_core += achievement->public_.points;

if (achievement->public_.type == RC_CLIENT_ACHIEVEMENT_TYPE_PROGRESSION)
++num_progression_achievements;
else if (achievement->public_.type == RC_CLIENT_ACHIEVEMENT_TYPE_WIN)
++num_win_condition_achievements;

if (achievement->public_.unlocked & unlock_bit) {
++summary->num_unlocked_achievements;
summary->points_unlocked += achievement->public_.points;
Expand All @@ -949,17 +954,12 @@ static void rc_client_subset_get_user_game_summary(const rc_client_subset_info_t
}
else if (achievement->public_.type == RC_CLIENT_ACHIEVEMENT_TYPE_WIN)
{
++num_win_condition_achievements;
first_win_condition_unlock = (first_win_condition_unlock == 0) ?
achievement->public_.unlock_time :
first_win_condition_unlock;
achievement->public_.unlock_time :
first_win_condition_unlock;
}
} else {
if (achievement->public_.type == RC_CLIENT_ACHIEVEMENT_TYPE_PROGRESSION)
++num_progression_achievements;
else if (achievement->public_.type == RC_CLIENT_ACHIEVEMENT_TYPE_WIN)
++num_win_condition_achievements;
}

if (achievement->public_.bucket == RC_CLIENT_ACHIEVEMENT_BUCKET_UNSUPPORTED) {
++summary->num_unsupported_achievements;
}
Expand Down
Loading