Remove visaelectron from card brands.
#244
Conversation
We don't differentiate other Visa-branded sub-Visa brands (e.g. "Visa Debit"), there aren't clear public BIN range distinctions, and we had some false positives. Users who really want to differentiate Visa Electron can add their own custom ranges. This is a breaking change.
|
Hey @jenanwise, I'm not sure that it makes sense to remove support for Visa Electron. Maestro is a sub-Mastercard in the same sense that Electron is sub-Visa, and in both cases, there are specific requirements about processing transactions on these cards (via 3d secure), so there's value in being able to distinguish them from the rest of their parent ranges. more info on Maestro here: http://www.maestrocard.com/uk/ more info on 3d secure here: https://support.stripe.com/questions/does-stripe-support-3d-secure-verified-by-visa-mastercard-securecode |
|
There are a few different uses of client-side BIN->brand detection:
Because perfect BIN data is not really publicly accessible, we have to balance the above needs with the cost of maintaining lossy mappings. You are correct that Maestro is a sub-brand of Mastercard, but unlike Visa Electron, it:
In a perfect world, we'd have a 0kb magic map from BIN to brand+sub-brands, but that's obviously not feasible. So, we have to make tradeoffs, and for this case I'd rather err on including Visa Electron in Visa. If detecting Visa Electron on the client is particularly important to you, and you have actionable BIN ranges, you should definitely extend I'm not sure I understand the 3dsecure comment. 3dsecure capabalities should probably be done at the server at the time of tokenization / whatever else your payment processor is doing, rather than being looked up statically on the client (again, due to lossy mappings). |
|
👍 |
r? @dotch
Summary
Remove
visaelectronfrom card brands.This is a breaking change. I will increment the next release to
2.0.0.Motivation
We don't differentiate other Visa-branded sub-Visa brands (e.g. "Visa Debit"),
there aren't clear public BIN range distinctions, and we had some false
positives (#243).
Users who really want to differentiate Visa Electron can add their own custom
ranges.
Testing
Removed test cases relating to Visa Electron.