This repository was archived by the owner on Jan 10, 2018. It is now read-only.
Remove 'elo' card type. #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elo is an important local brand. However, the bin ranges are very scattered, and it impossible with our current implementation to have both comprehensive coverage and a bin pattern list that is not overly long. Users who need Elo can always extend `$.payment.cards`.
Closed
|
Could you update the README to remove mentions of |
|
@shaunstripe Good catch! Done. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @shaunstripe
Summary
Remove 'elo' card type.
This is a breaking change. We'll cut a new major release. See #244 for somewhat similar prior removal of a card type.
Motivation
Elo is an important local brand. However, the bin ranges are very
scattered, and it impossible with our current implementation to have
both comprehensive coverage and a bin pattern list that is not overly
long / difficult to maintain.
Users who need Elo can always extend
$.payment.cards.See some discussion in #246.
Testing
Removed Elo test cases. Existing test suite passes.