Revert globalization of Swagger descriptions [2.x] #2621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
force-pushed
the
fix/unglobalize-swagger-2x
branch
from
9d125fc to
0220ea3
Compare
|
Other than the 1 comment, the rest LGTM. |
| @@ -7,12 +7,11 @@ | |||
| * Module Dependencies. | |||
| */ | |||
|
|
|||
| var g = require('strong-globalize')(); | |||
There was a problem hiding this comment.
You can't remove this line. Other places in this file are using it and failing CI linter.
There was a problem hiding this comment.
Oh of course, this was not intentional. Will fix.
bajtos
force-pushed
the
fix/unglobalize-swagger-2x
branch
from
0220ea3 to
30df9ec
Compare
bajtos
force-pushed
the
fix/unglobalize-swagger-2x
branch
from
30df9ec to
7932d75
Compare
bajtos
changed the title
|
This was exactly what I was looking for. OAI/OpenAPI-Specification#274 was closed (by a missunderstanding I think) :( I wish this was not reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in SlackChat, Swagger descriptions should not be globalized. Translating Swagger is an open problem, see e.g. OAI/OpenAPI-Specification#274
@0candy please review