Skip to content

Revert globalization of Swagger descriptions #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2016
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Aug 15, 2016

This is a forward-port of #2621:

As discussed in SlackChat, Swagger descriptions should not be globalized. Translating Swagger is an open problem, see e.g. OAI/OpenAPI-Specification#274

@0candy please review

@0candy
Copy link
Contributor

0candy commented Aug 15, 2016

LGTM. There is one more, if you can revert that line too. Thanks!
https://github.com/strongloop/loopback/blob/master/example/mobile-models/app.js#L46

Edit: Sorry, that wasn't a swagger description. Please ignore. ^

@bajtos bajtos merged commit da0a543 into master Aug 16, 2016
@bajtos bajtos deleted the fix/unglobalize-swagger branch August 16, 2016 11:59
@bajtos bajtos removed the #review label Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants