chore: test matrix dimension for vite #15208

dominikg · 2026-01-26T16:42:05Z

this allows us to test with different vite majors

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

changeset-bot · 2026-01-26T16:42:09Z

⚠️ No Changeset found

Latest commit: 07365e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

benmccann · 2026-01-26T17:06:53Z

Looks like this is failing the CI:

Run yq -i '. + {overrides: .catalogs."vite-beta"}' pnpm-workspace.yaml
Error: 1:6: lexer: invalid input text "overrides: .cata..."
Error: Process completed with exit code 1.

But happy to merge it once it's passing

elliott-with-the-longest-name-on-github · 2026-01-26T18:44:08Z

Something seems to still be freaking out, looks like a broken lockfile replacement maybe?

dominikg · 2026-01-26T21:41:07Z

the baseline test passed locally for me using node18, not sure what difference CI makes here.
the beta test failed on different tests the app where it failed here passed.

…ace consistency, add test matrix dimension and tests for vite5 and vite8

…heck in types test

…nsure tests work with retry and conters are independent

…de18

…kip the test anyways and it would fail

dominikg · 2026-01-28T15:11:55Z

.github/workflows/ci.yml

          - node-version: 18
            os: ubuntu-latest
            e2e-browser: 'chromium'
+            vite: 'baseline'


introduces a new matrix dimension called vite with 3 values

baseline: the lowest version of vite we support (peer range of sveltekit)
current: the version of vite currently in the lockfile
beta: the upcoming beta version of vite

dominikg · 2026-01-28T15:13:25Z

.github/workflows/ci.yml

+      - name: setup overrides for matrix.vite
+        if: matrix.vite != 'current'
+        run: | # copies catalogs.vite-xxx to overrides in pnpm-workspace.yaml so the subsequent `pnpm install` enforces them
+          yq -i '.overrides =.catalogs."vite-${{matrix.vite}}"' pnpm-workspace.yaml


yq is available on github hosted runners (except windows) and allows in place editing of yaml

this code copies a block of catalogs.vite-baseline into overrides so tha the install that we run afterwards enforces these versions. see pnpm-workspace.yaml for details

dominikg · 2026-01-28T15:16:04Z

.github/workflows/ci.yml

      matrix:
        include:
-          - node-version: 18
+          - node-version: 24


node 18 caused build fails with newer versions of vite-plugin-svelte@6 that uses node:util styleText.

these tests are for browser behavior so i think its ok to update to 24 which should make them a bit more efficient (24 is faster than 18)
same goes for vite6

dominikg · 2026-01-28T15:16:46Z

.github/workflows/ci.yml

+      - name: setup overrides for matrix.node
+        if: matrix.node-version == 18
+        run: | # copies catalogs.node-xx to overrides in pnpm-workspace.yaml so the subsequent `pnpm install` enforces them
+          yq -i '.overrides =.catalogs."node-18"' pnpm-workspace.yaml


similar to vite-baseline we have to pick versions that support node18 here otherwise it can break.

dominikg · 2026-01-28T15:17:56Z

packages/kit/test/apps/async/src/routes/remote/event/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { get_event } from './data.remote.js';
+	import { get_event } from './data.remote.ts';


concession change for vite5, it doesn't work with data.remote.js on node 18, allowing .ts import and changing the imported suffix works.

packages/kit/test/utils.js

dominikg · 2026-01-28T15:21:49Z

scripts/sync-all.js

 		const cwd = path.join(directories, dir);

-		if (!fs.existsSync('svelte.config.js')) {
+		if (!fs.existsSync(path.join(cwd,'svelte.config.js'))) {


without this, sync-all does nothing which caused one test with vite8 to fail because rolldown does not like missing .svelte-kit/tsconfig.json

the missing tsconfig causing an error has been fixed in latest vite8 beta, but this fix to sync-all should still be done

dominikg · 2026-01-28T15:26:23Z

one thing i havn't fully wrapped my head around yet is if these overrides could lead to dependency cache poisoning. that could happen if pnpm action pruned unused vite from the cached pnpm store and a test with these overrides finished first and gets to write it.

teemingc · 2026-02-04T06:03:13Z

Seems like one of the CI checks is failing consistently. Something about $app/read not working.

dominikg · 2026-02-04T10:15:24Z

it's been passing for me locally so i kind of have a hard time reproducing/analyzing it. might have to download the playwright trace and go from there. If anyone can replicate by using node18 an the overrides from the baseline catalog please help :)

packages/enhanced-img/test/apps/basics/test/test.js

packages/enhanced-img/test/utils.js

packages/kit/test/apps/async/test/client.test.js

benmccann · 2026-02-04T20:04:31Z

packages/kit/test/utils.js

 		port: process.env.DEV ? 5173 : 4173
 	},
-	retries: process.env.CI ? 2 : 0,
+	retries: 2, // some tests are flaky especially on overloaded systems, so allow retry


I preferred it failing locally as it was easier to see what was going wrong and gave more incentive to fix it

not sure that incentive is working then because they failed on me without any changes from main more often than not.

@benmccann i can change it to

/** * @param {string} name * @param {number} default_value * @return {number} */ function number_from_env(name,default_value) { return ( process.env[name] != null) ? Number(process.env[name]) : default_value } /* ...*/ retries: process.env.CI ? 2 : number_from_env('SVELTEKIT_PLAYWRIGHT_RETRIES',0),

so you could run it with SVELTEKIT_PLAYWRIGHT_RETRIES=2 pnpm test:kit locally but default would still be no retries

same for the workers change

that works for me

added KIT_E2E_WORKERS and KIT_E2E_RETRIES (we already had KIT_E2E_BROWSER) in all configs and a shared util to read number from env

the util lives somewhat awkwardly in the root, but i didn't want to introduce a workspace package. If anyone has ideas how to better share it or if it should be inlined into the 4 files thats fine with me too

Co-authored-by: Ben McCann <[email protected]>

dominikg · 2026-02-05T10:35:26Z

one thing i havn't fully wrapped my head around yet is if these overrides could lead to dependency cache poisoning. that could happen if pnpm action pruned unused vite from the cached pnpm store and a test with these overrides finished first and gets to write it.

we are using the cache feature of actions/setup-node which caches the pnpm store and not just local node_modules and it does not prune, so no poisoning here actions/setup-node#1428 (also searched their code, they don't)

These tests are also slower than others that use the cache with the same key so they are very unlikely to succeed in trying to store it.

If we still feel this is too risky, we'd have to disable caching on setup-node if vite dimension is not current

teemingc

Thank you!

benmccann approved these changes Jan 26, 2026

View reviewed changes

dominikg added 14 commits January 28, 2026 11:45

chore: add vite8 overrides

65ca241

chore: update local vite version to v7, use override to ensure worksp…

1b7404b

…ace consistency, add test matrix dimension and tests for vite5 and vite8

fix: update baseline vite version to actual minimum and disable lib c…

a14cdf6

…heck in types test

revert to main

9fd05df

use overrides for text matrix and define version in extra catalogs

6580571

fix: remove Y flag and add vite to failure name

05baea8

fix yq syntax, githubt uses yqgo https://mikefarah.gitbook.io/yq

ae7d6d1

fix pnpm install

5588e6f

fix: remove accidentally commited overrides

3496c21

lets see if these change make vite5 tests pass

3815483

more stable local testing

f294dc0

fix: introduce per server file state util in test app and use it to e…

367d88a

…nsure tests work with retry and conters are independent

fix: account for build using _ instead of + in +server.js files

1e6e37d

remove debug code and format

710e60a

dominikg force-pushed the chore/test-matrix-vite branch from 2557112 to 710e60a Compare January 28, 2026 10:49

dominikg added 8 commits January 28, 2026 13:34

fix: override vite and vps for node18

59922ca

fix: move cross-browser tests to node24, skip enhanced-img test on no…

d15c494

…de18

fix: don't call build on playwright webServer when using node18, we s…

53f748a

…kip the test anyways and it would fail

format

dbe2945

fix: ignore failing testcase for vite5+node18 combo

8be7f02

chore: fix sync-all

4b5500f

fix: add missing sync calls to some test apps

10bf2f4

format, i really need some auto format on commit :/

46e0186

dominikg commented Jan 28, 2026

View reviewed changes

packages/kit/test/utils.js Outdated Show resolved Hide resolved

dominikg commented Jan 28, 2026

View reviewed changes

dominikg and others added 2 commits February 3, 2026 17:08

Merge branch 'main' into chore/test-matrix-vite

d946e80

Merge branch 'main' into chore/test-matrix-vite

88c31a2

teemingc added the vite label Feb 4, 2026

fix: bump vite5 version for baseline test to avoid errors in testsuite

1afe3dc

benmccann reviewed Feb 4, 2026

View reviewed changes

packages/enhanced-img/test/apps/basics/test/test.js Show resolved Hide resolved

benmccann reviewed Feb 4, 2026

View reviewed changes

packages/enhanced-img/test/utils.js Show resolved Hide resolved

benmccann reviewed Feb 4, 2026

View reviewed changes

packages/kit/test/apps/async/test/client.test.js Outdated Show resolved Hide resolved

benmccann reviewed Feb 4, 2026

View reviewed changes

Apply suggestions from code review

f5c5de8

Co-authored-by: Ben McCann <[email protected]>

dominikg added 3 commits February 6, 2026 16:32

Merge branch 'main' into chore/test-matrix-vite

4c1dfbb

refactor: allow defining retries and workers from env for local testing

cc22b8b

chore: format

07365e1

teemingc approved these changes Feb 11, 2026

View reviewed changes

teemingc merged commit 2f3a007 into main Feb 11, 2026
26 checks passed

teemingc deleted the chore/test-matrix-vite branch February 11, 2026 16:48

Uh oh!

chore: test matrix dimension for vite #15208

chore: test matrix dimension for vite #15208

Conversation

dominikg commented Jan 26, 2026 • edited by teemingc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

Edits

Uh oh!

changeset-bot bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

benmccann commented Jan 26, 2026

Uh oh!

elliott-with-the-longest-name-on-github commented Jan 26, 2026

Uh oh!

dominikg commented Jan 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dominikg Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dominikg commented Jan 28, 2026

Uh oh!

teemingc commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominikg commented Feb 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dominikg commented Feb 5, 2026

Uh oh!

teemingc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dominikg commented Jan 26, 2026 •

edited by teemingc

Loading

changeset-bot bot commented Jan 26, 2026 •

edited

Loading

dominikg Jan 28, 2026 •

edited

Loading

teemingc commented Feb 4, 2026 •

edited

Loading