chore: test matrix dimension for vite

.github/workflows/ci.yml

@@ -54,17 +54,26 @@ jobs:
           - node-version: 18
             os: ubuntu-latest
             e2e-browser: 'chromium'
+            vite: 'baseline'
           - node-version: 20
             os: ubuntu-latest
             e2e-browser: 'chromium'
+            vite: 'current'
           - node-version: 22
             os: ubuntu-latest
             e2e-browser: 'chromium'
+            vite: 'current'
           - node-version: 24
             os: ubuntu-latest
             e2e-browser: 'chromium'
+            vite: 'current'
+          - node-version: 24
+            os: ubuntu-latest
+            e2e-browser: 'chromium'
+            vite: 'beta'
     env:
       KIT_E2E_BROWSER: ${{matrix.e2e-browser}}
+      MATRIX_VITE: ${{matrix.vite}}
     steps:
       - run: git config --global core.autocrlf false
       - uses: actions/checkout@v6
@@ -74,6 +83,13 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: pnpm
       - run: pnpm install --frozen-lockfile
+      - name: setup overrides for matrix.vite
+        if: matrix.vite != 'current'
+        run: | # copies catalogs.vite-xxx to overrides in pnpm-workspace.yaml so the subsequent `pnpm install` enforces them
+          yq -i '.overrides =.catalogs."vite-${{matrix.vite}}"' pnpm-workspace.yaml
+          pnpm install --no-frozen-lockfile
+          git checkout pnpm-lock.yaml pnpm-workspace.yaml # revert changes to pnpm files to avoid cache key changes
+          pnpm --dir packages/kit ls vite
       - run: pnpm playwright install ${{ matrix.e2e-browser }}
       - run: pnpm run sync-all
       - run: pnpm test:kit
@@ -90,7 +106,7 @@ jobs:
         uses: actions/upload-artifact@v6
         with:
           retention-days: 3
-          name: test-failure-${{ github.run_id }}-${{ matrix.os }}-${{ matrix.node-version }}-${{ matrix.e2e-browser }}
+          name: test-failure-${{ github.run_id }}-${{ matrix.os }}-${{ matrix.node-version }}-${{ matrix.e2e-browser }}-vite-${{matrix.vite}}
           path: test-results.tar.gz
   test-kit-cross-browser:
     runs-on: ${{ matrix.os }}
@@ -99,27 +115,27 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - node-version: 18
+          - node-version: 24
             os: windows-latest
             e2e-browser: 'chromium'
             mode: 'dev'
-          - node-version: 18
+          - node-version: 24
             os: ubuntu-latest
             e2e-browser: 'firefox'
             mode: 'dev'
-          - node-version: 18
+          - node-version: 24
             os: macOS-latest
             e2e-browser: 'webkit'
             mode: 'dev'
-          - node-version: 18
+          - node-version: 24
             os: windows-latest
             e2e-browser: 'chromium'
             mode: 'build'
-          - node-version: 18
+          - node-version: 24
             os: ubuntu-latest
             e2e-browser: 'firefox'
             mode: 'build'
-          - node-version: 18
+          - node-version: 24
             os: macOS-latest
             e2e-browser: 'webkit'
             mode: 'build'
@@ -235,6 +251,13 @@ jobs:
         with:
           deno-version: ^2.2.4
       - run: pnpm install --frozen-lockfile
+      - name: setup overrides for matrix.node
+        if: matrix.node-version == 18
+        run: | # copies catalogs.node-xx to overrides in pnpm-workspace.yaml so the subsequent `pnpm install` enforces them
+          yq -i '.overrides =.catalogs."node-18"' pnpm-workspace.yaml
+          pnpm install --no-frozen-lockfile
+          git checkout pnpm-lock.yaml pnpm-workspace.yaml # revert changes to pnpm files to avoid cache key changes
+          pnpm --dir packages/kit ls vite @sveltejs/vite-plugin-svelte
       - run: pnpm playwright install chromium
       - run: cd packages/kit && pnpm prepublishOnly
       - run: pnpm run test:others

packages/adapter-cloudflare/test/utils.js

@@ -1,5 +1,6 @@
 import { devices } from '@playwright/test';
 import process from 'node:process';
+import { number_from_env } from '../../../test-utils/index.js';
 
 /** @type {import('@playwright/test').PlaywrightTestConfig} */
 export const config = {
@@ -10,7 +11,7 @@ export const config = {
 		command: process.env.DEV ? 'pnpm dev' : 'pnpm build && pnpm preview',
 		port: process.env.DEV ? 5173 : 8787
 	},
-	retries: process.env.CI ? 2 : 0,
+	retries: process.env.CI ? 2 : number_from_env('KIT_E2E_RETRIES', 0),
 	projects: [
 		{
 			name: 'chromium'
@@ -21,7 +22,7 @@ export const config = {
 		screenshot: 'only-on-failure',
 		trace: 'retain-on-failure'
 	},
-	workers: process.env.CI ? 2 : undefined,
+	workers: process.env.CI ? 2 : number_from_env('KIT_E2E_WORKERS', undefined),
 	reporter: 'list',
 	testDir: 'test',
 	testMatch: /(.+\.)?(test|spec)\.[jt]s/

packages/adapter-netlify/test/utils.js

@@ -1,5 +1,6 @@
 import { devices } from '@playwright/test';
 import process from 'node:process';
+import { number_from_env } from '../../../test-utils/index.js';
 
 /** @type {import('@playwright/test').PlaywrightTestConfig} */
 export const config = {
@@ -10,7 +11,7 @@ export const config = {
 		command: 'pnpm build && pnpm preview',
 		port: 8888
 	},
-	retries: process.env.CI ? 2 : 0,
+	retries: process.env.CI ? 2 : number_from_env('KIT_E2E_RETRIES', 0),
 	projects: [
 		{
 			name: 'chromium'
@@ -21,7 +22,7 @@ export const config = {
 		screenshot: 'only-on-failure',
 		trace: 'retain-on-failure'
 	},
-	workers: process.env.CI ? 2 : undefined,
+	workers: process.env.CI ? 2 : number_from_env('KIT_E2E_WORKERS', undefined),
 	reporter: 'list',
 	testDir: 'test',
 	testMatch: /(.+\.)?(test|spec)\.[jt]s/

packages/adapter-static/test/utils.js

@@ -1,5 +1,6 @@
 import { devices } from '@playwright/test';
 import process from 'node:process';
+import { number_from_env } from '../../../test-utils/index.js';
 
 /** @type {import('@playwright/test').PlaywrightTestConfig} */
 export const config = {
@@ -10,7 +11,7 @@ export const config = {
 		command: 'pnpm build && pnpm preview',
 		port: 5173
 	},
-	retries: process.env.CI ? 2 : 0,
+	retries: process.env.CI ? 2 : number_from_env('KIT_E2E_RETRIES', 0),
 	projects: [
 		{
 			name: 'chromium'
@@ -21,7 +22,7 @@ export const config = {
 		screenshot: 'only-on-failure',
 		trace: 'retain-on-failure'
 	},
-	workers: process.env.CI ? 2 : undefined,
+	workers: process.env.CI ? 2 : number_from_env('KIT_E2E_WORKERS', undefined),
 	reporter: 'list',
 	testDir: 'test',
 	testMatch: /(.+\.)?(test|spec)\.[jt]s/

packages/enhanced-img/test/apps/basics/test/test.js

@@ -1,5 +1,8 @@
 import { expect, test } from '@playwright/test';
-
+import process from 'node:process';
+const is_node18 = process.versions.node.startsWith('18.');
+// TODO: remove with SvelteKit 3
+test.skip(is_node18, 'enhanced-img requires vite-plugin-svelte@6 which requires node20');
 test('images are properly rendered', async ({ page }) => {
 	await page.goto('/');
 

packages/enhanced-img/test/utils.js

@@ -1,16 +1,22 @@
 import { devices } from '@playwright/test';
 import process from 'node:process';
+import { number_from_env } from '../../../test-utils/index.js';
 
+// TODO: remove with SvelteKit 3
+const is_node18 = process.versions.node.startsWith('18.');
 /** @type {import('@playwright/test').PlaywrightTestConfig} */
 export const config = {
 	forbidOnly: !!process.env.CI,
 	// generous timeouts on CI
 	timeout: process.env.CI ? 45000 : 15000,
-	webServer: {
-		command: 'pnpm build && pnpm preview',
-		port: 4173
-	},
-	retries: process.env.CI ? 2 : 0,
+	webServer: is_node18
+		? undefined
+		: {
+				// do not try to build on node18
+				command: 'pnpm build && pnpm preview',
+				port: 4173
+			},
+	retries: process.env.CI ? 2 : number_from_env('KIT_E2E_RETRIES', 0),
 	projects: [
 		{
 			name: 'chromium'
@@ -21,7 +27,7 @@ export const config = {
 		screenshot: 'only-on-failure',
 		trace: 'retain-on-failure'
 	},
-	workers: process.env.CI ? 2 : undefined,
+	workers: process.env.CI ? 2 : number_from_env('KIT_E2E_WORKERS', undefined),
 	reporter: 'list',
 	testDir: 'test',
 	testMatch: /(.+\.)?(test|spec)\.[jt]s/

packages/kit/src/core/sync/write_types/index.spec.js

@@ -1,6 +1,7 @@
 import { execSync } from 'node:child_process';
 import fs from 'node:fs';
 import path from 'node:path';
+import process from 'node:process';
 import { fileURLToPath } from 'node:url';
 import { assert, expect, test } from 'vitest';
 import { rimraf } from '../../../utils/filesystem.js';
@@ -43,7 +44,11 @@ test('Creates correct $types', { timeout: 60000 }, () => {
 	for (const dir of directories) {
 		run_test(dir);
 		try {
-			execSync('pnpm testtypes', { cwd: path.join(cwd, dir) });
+			// we skip lib check if MATRIX_VITE is set and not 'current' because overrides for vite can cause type mismatches
+			const skipLibCheck = process.env.MATRIX_VITE != null && process.env.MATRIX_VITE !== 'current';
+			execSync(`pnpm testtypes${skipLibCheck ? ' --skipLibCheck' : ''}`, {
+				cwd: path.join(cwd, dir)
+			});
 		} catch (e) {
 			console.error(/** @type {any} */ (e).stdout.toString());
 			throw new Error(`${dir} type tests failed`);

packages/kit/test/apps/async/src/routes/remote/event/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { get_event } from './data.remote.js';
+	import { get_event } from './data.remote.ts';
 
 	const event = await get_event();
 </script>

packages/kit/test/apps/async/src/routes/remote/form/[test_name]/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { get_message, set_message, resolve_deferreds } from './form.remote.js';
+	import { get_message, set_message, resolve_deferreds } from './form.remote.ts';
 
 	const { params } = $props();
 

packages/kit/test/apps/async/src/routes/remote/form/preflight-only/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { get, set } from './form.remote.js';
+	import { get, set } from './form.remote.ts';
 	import * as v from 'valibot';
 
 	const data = get();

packages/kit/test/apps/async/src/routes/remote/form/preflight/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { get_number, set_number } from './form.remote.js';
+	import { get_number, set_number } from './form.remote.ts';
 	import * as v from 'valibot';
 
 	const number = get_number();

packages/kit/test/apps/async/src/routes/remote/form/select-untouched/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { myform } from './form.remote.js';
+	import { myform } from './form.remote.ts';
 </script>
 
 <form {...myform}>

packages/kit/test/apps/async/src/routes/remote/form/submitter/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { my_form } from './form.remote.js';
+	import { my_form } from './form.remote.ts';
 </script>
 
 <form {...my_form}>

packages/kit/test/apps/async/src/routes/remote/form/underscore/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { register } from './form.remote.js';
+	import { register } from './form.remote.ts';
 </script>
 
 <form {...register}>

packages/kit/test/apps/async/src/routes/remote/form/validate/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { issue_path_form, my_form, my_form_2 } from './form.remote.js';
+	import { issue_path_form, my_form, my_form_2 } from './form.remote.ts';
 	import * as v from 'valibot';
 
 	const schema = v.object({

packages/kit/test/apps/async/src/routes/remote/form/value/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { values } from './value.remote.js';
+	import { values } from './value.remote.ts';
 </script>
 
 <h1>Remote Form Value Test</h1>

packages/kit/test/apps/async/src/routes/remote/query-non-exported/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { total } from './data.remote.js';
+	import { total } from './data.remote.ts';
 </script>
 
 <h1>{await total()}</h1>

packages/kit/test/apps/async/src/routes/remote/transport/+page.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { greeting } from './data.remote.js';
+	import { greeting } from './data.remote.ts';
 </script>
 
 <h1>{(await greeting()).bar()}</h1>

packages/kit/test/apps/async/test/client.test.js

@@ -1,21 +1,27 @@
 import process from 'node:process';
 import { expect } from '@playwright/test';
 import { test } from '../../../utils.js';
+const is_node18 = process.versions.node.startsWith('18.');
+import { version as vite_version } from 'vite';
+const is_vite5 = vite_version.startsWith('5.');
 
 test.skip(({ javaScriptEnabled }) => !javaScriptEnabled);
 
 test.describe('remote functions', () => {
 	test('preloading data works when the page component and server load both import a remote function', async ({
-		page
+		page,
+		clicknav
 	}) => {
 		test.skip(!process.env.DEV, 'remote functions are only analysed in dev mode');
+		// TODO: remove with SvelteKit 3
+		test.skip(is_node18 && is_vite5, 'vite5 in node18 fails to resolve remote function export');
 		await page.goto('/remote/dev');
 		await page.locator('a[href="/remote/dev/preload"]').hover();
 		await Promise.all([
 			page.waitForTimeout(100), // wait for preloading to start
 			page.waitForLoadState('networkidle') // wait for preloading to finish
 		]);
-		await page.click('a[href="/remote/dev/preload"]');
+		await clicknav('a[href="/remote/dev/preload"]', { waitForURL: '/remote/dev/preload' });
 		await expect(page.locator('p')).toHaveText('foobar');
 	});
 });

packages/kit/test/apps/async/tsconfig.json

@@ -4,7 +4,8 @@
 		"checkJs": true,
 		"esModuleInterop": true,
 		"noEmit": true,
-		"resolveJsonModule": true
+		"resolveJsonModule": true,
+		"allowImportingTsExtensions": true
 	},
 	"extends": "./.svelte-kit/tsconfig.json"
 }

packages/kit/test/apps/basics/src/routes/load/invalidation/forced-goto/+layout.server.js

@@ -1,7 +1,7 @@
-import { increment } from './state';
+import { increment } from '../../state.js';
 
 export const load = () => {
 	return {
-		a: increment()
+		a: increment(import.meta.url)
 	};
 };

packages/kit/test/apps/basics/src/routes/load/invalidation/forced-goto/+page.server.js

@@ -1,7 +1,6 @@
-import { increment } from './state';
-
+import { increment } from '../../state.js';
 export const load = () => {
 	return {
-		b: increment()
+		b: increment(import.meta.url)
 	};
 };

packages/kit/test/apps/basics/src/routes/load/invalidation/forced-goto/reset-states/+server.js

@@ -0,0 +1,6 @@
+import { reset_states } from '../../../state.js';
+import { json } from '@sveltejs/kit';
+
+export const POST = () => {
+	return json(reset_states(import.meta.url));
+};