Skip to content

fix: take outroing elements out of the flow when animating siblings#11208

Merged
Rich-Harris merged 2 commits into
mainfrom
gh-10867
Apr 17, 2024
Merged

fix: take outroing elements out of the flow when animating siblings#11208
Rich-Harris merged 2 commits into
mainfrom
gh-10867

Conversation

@Rich-Harris

@Rich-Harris Rich-Harris commented Apr 17, 2024

Copy link
Copy Markdown
Member

No test because you can't really test for this stuff in JSDOM. Fixes #10867

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot

changeset-bot Bot commented Apr 17, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 92db5b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

trueadm
trueadm approved these changes Apr 17, 2024
View reviewed changes

@trueadm trueadm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Rich-Harris
Rich-Harris merged commit c44234d into main Apr 17, 2024
@Rich-Harris
Rich-Harris deleted the gh-10867 branch April 17, 2024 20:54
@github-actions github-actions Bot mentioned this pull request Apr 17, 2024
Merged
@brunnerh brunnerh mentioned this pull request Apr 17, 2024
Closed
Rich-Harris added a commit that referenced this pull request Apr 18, 2024
@Rich-Harris
Revert "fix: take outroing elements out of the flow when animating si…
3a6a482 
…blings (#11208)"

This reverts commit c44234d.
@Rich-Harris Rich-Harris mentioned this pull request Apr 18, 2024
Merged
5 tasks
Rich-Harris added a commit that referenced this pull request Apr 18, 2024
@Rich-Harris
fix: measure elements before taking siblings out of the flow (#11216)
5665498 
* Revert "fix: take outroing elements out of the flow when animating siblings (#11208)"

This reverts commit c44234d.

* fix: measure elements before taking siblings out of the flow

* lint

* add changeset back

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trueadm trueadm trueadm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Svelte 5: FLIP animations don't take outroing elements out of the flow

2 participants

@Rich-Harris @trueadm