fix: measure elements before taking siblings out of the flow#11216
Merged
Conversation
🦋 Changeset detectedLatest commit: 8276f45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
trueadm
approved these changes
Apr 18, 2024
Rich-Harris
marked this pull request as draft
April 18, 2024 11:20
Member
Author
|
Converted to draft because I forgot to undelete the reverted changeset and add a new one - will do that when at my laptop |
Rich-Harris
marked this pull request as ready for review
April 18, 2024 12:50
This was referenced Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #11208 and implements position fixing in a slightly more logical way that also fixes #10251. It's still not perfect, — it's possible to cause short-lived glitches if you have lots of transitions and animations rapidly interacting — but it's better than Svelte 4. We can worry about perfection another time (possibly with a redesigned primitive).
As with #11208, no test because you can't really test this stuff in JSDOM.
This also fixes #11156 and #11199, by removing animations once they have completed.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint