chore: improve SSR invalid element error message#11585
Merged
Rich-Harris merged 13 commits intomainfrom May 14, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: f647f30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
I didn't realise we were doing this |
Contributor
Author
|
@Rich-Harris The issue was that no one was seeing that error and if we threw an actual error than the server instance would go down and that wasn't great. Since introducing |
5 tasks
…ent is guaranteed to not be null
Rich-Harris
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make error messages for invalid elements during SSR better, as it lets you know what component the element is in. Addressing part of the problem from #10630. In a follow up, once I have time, it would be good to add line numbers too to the filenames.
Before
After
