chore: dedupe getLocator
calls
#11600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #11585, I thought it'd be worth printing the element locations as well as the filenames. To do that, we need to use
getLocator
. We're already doing that in multiple places, quite unnecessarily, and I didn't want to add yet another one.This PR introduces compiler state, which includes
warnings
, the currentfilename
, and alocator
that can be used in multiple places — during parsing, when hitting warnings and errors, and when generating those SSR messages.Once this is merged, it'll be trivial to add element locations to #11585.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint