chore: null out current_batch before committing branches#17809
Merged
dummdidumm merged 2 commits intomainfrom Feb 26, 2026
Merged
chore: null out current_batch before committing branches#17809dummdidumm merged 2 commits intomainfrom
dummdidumm merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: fe8f658 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
dummdidumm
approved these changes
Feb 26, 2026
Merged
6 tasks
Rich-Harris
added a commit
that referenced
this pull request
Feb 26, 2026
another extraction from #17805. I always felt bad about `this.process([])`, and this PR replaces it with the steps that actually occur — even though this is arguably duplicative, I find it much easier to understand. It also allows us to avoid activating batches with no queued effects, thanks to the change in #17809. This saves us a bit of work in a not-that-uncommon case. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [ ] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`
Rich-Harris
pushed a commit
that referenced
this pull request
Feb 27, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.53.6 ### Patch Changes - perf: optimize parser hot paths for faster compilation ([#17811](#17811)) - fix: `SvelteMap` incorrectly handles keys with `undefined` values ([#17826](#17826)) - fix: SvelteURL `search` setter now returns the normalized value, matching native URL behavior ([#17828](#17828)) - fix: visit synthetic value node during ssr ([#17824](#17824)) - fix: always case insensitive event handlers during ssr ([#17822](#17822)) - chore: more efficient effect scheduling ([#17808](#17808)) - perf: optimize compiler analysis phase ([#17823](#17823)) - fix: skip redundant batch.apply ([#17816](#17816)) - chore: null out current_batch before committing branches ([#17809](#17809)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small tweak extracted from #17805, just to make that diff a bit more legible.
By passing the
batchto the branch commit callback, we don't need to rely on the value ofcurrent_batchbeing the same as the batch currently being processed. That gives us more control over the order of operations — for example we can null outcurrent_batchbefore committing branches, which is important (at present, if a state change occurs while those branches are being committed, it will belong to the current batch, but the resulting effects will happen in the context of a new batch, which is something we need to avoid for the sake of #17805).Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint