fix: SvelteMap incorrectly handles keys with undefined values#17826
Merged
Rich-Harris merged 5 commits intosveltejs:mainfrom Feb 27, 2026
Merged
fix: SvelteMap incorrectly handles keys with undefined values#17826Rich-Harris merged 5 commits intosveltejs:mainfrom
undefined values#17826Rich-Harris merged 5 commits intosveltejs:mainfrom
Conversation
`SvelteMap.has()` and `SvelteMap.get()` used `super.get(key) !== undefined` to check if a key exists, which returns a false negative when the value is legitimately `undefined`. Replaced with `super.has(key)`. Also fixed `SvelteMap.delete()` to trigger reactive updates (size + version) whenever a key is actually deleted, not only when a per-key source existed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9f7abd4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The test should be in |
The set() optimization to skip reactivity for same-value constructor- initialized keys isn't safe — re-setting a mutated object with the same reference should still trigger updates. Reverted to always trigger when no source exists. Also cleaned up test comments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move SvelteMap undefined values test from tests/signals/test.ts to src/reactivity/map.test.ts per PR feedback. Add test for delete() triggering size reactivity on keys without per-key sources. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
Feb 27, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.53.6 ### Patch Changes - perf: optimize parser hot paths for faster compilation ([#17811](#17811)) - fix: `SvelteMap` incorrectly handles keys with `undefined` values ([#17826](#17826)) - fix: SvelteURL `search` setter now returns the normalized value, matching native URL behavior ([#17828](#17828)) - fix: visit synthetic value node during ssr ([#17824](#17824)) - fix: always case insensitive event handlers during ssr ([#17822](#17822)) - chore: more efficient effect scheduling ([#17808](#17808)) - perf: optimize compiler analysis phase ([#17823](#17823)) - fix: skip redundant batch.apply ([#17816](#17816)) - chore: null out current_batch before committing branches ([#17809](#17809)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SvelteMaphad two bugs related to how it checked for key existence internally:1.
has()andget()returned wrong results for keys withundefinedvaluesBoth methods used
super.get(key) !== undefinedto determine if a key existed before creating a per-key reactive source. This fails for keys whose value is legitimatelyundefined, causing:has(key)to returnfalsefor existing keys withundefinedvaluesget(key)to skip creating a per-key source and fall back to trackingversion, resulting in over-notificationFix: Replace
super.get(key) !== undefinedwithsuper.has(key)in bothhas()andget(), matching the pattern already used inSvelteSet.2.
delete()skipped reactive updates when a key had no per-key sourceThe
sizeandversionreactive updates were inside theif (s !== undefined)block, meaning they only fired when a per-key source existed (i.e., someone had previously calledhas()orget()on that specific key). If a key was added via the constructor orset()but never individually read, deleting it would not trigger reactive updates for effects depending onsizeor iterators.Fix: Move
set(this.#size, super.size)andincrement(this.#version)to a separateif (res)block so they fire whenever a key is actually deleted, regardless of whether a per-key source existed.Before fix
After fix
Test plan
Tests are in
packages/svelte/src/reactivity/map.test.ts:map.has()returnstruefor constructor-initialized keys withundefinedvaluesmap.get()returnsundefinedwith proper per-key reactive trackingmap.delete()triggershas()/get()reactivity for undefined-valued keysmap.set(key, undefined)followed byhas()/get()works correctlymap.delete()triggerssizereactivity for keys that were never individually read (no per-key source)🤖 Generated with Claude Code